Bug 727252

Summary: Review Request: verne-kde-theme - Verne KDE Theme
Product: [Fedora] Fedora Reporter: Jaroslav Reznik <jreznik>
Component: Package ReviewAssignee: Radek Novacek <rnovacek>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, ovasik, package-review, rnovacek
Target Milestone: ---Flags: rnovacek: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-02 14:40:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jaroslav Reznik 2011-08-01 16:42:46 UTC 
Spec URL: http://rezza.hofyland.cz/fedora/packages/verne-kde-theme/verne-kde-theme.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/verne-kde-theme/verne-kde-theme-15.91.0-1.fc14.src.rpm
Description: This is Verne KDE Theme Artwork containing KDM theme,
KSplash theme and Plasma Workspaces theme.
Comment 1 Radek Novacek 2011-08-01 17:28:24 UTC 
RPMlint output:
    verne-kde-theme.spec:59: W: macro-in-comment %{buildroot}
    verne-kde-theme.spec:59: W: macro-in-comment %{_kde4_appsdir}
Not an issue.

    verne-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Verne/system-logo-white.png ../../../../../pixmaps/system-logo-white.png
    <same warning few more times>
/usr/share/pixmaps/system-logo-white.png is from package fedora-logos, which provides system-logos required by this package, so not an issue.
    2 packages and 1 specfiles checked; 0 errors, 9 warnings.

Issues:
Typo in the %changelog section: Mon Aug 00 2011


No serious problems found -> setting review+
Comment 2 Jaroslav Reznik 2011-08-01 18:25:54 UTC 
Thanks,
changelog fixed. This package is mostly sed s/lovelock/verne to match current wallpaper and we want it to alpha.
Comment 3 Jaroslav Reznik 2011-08-01 18:27:26 UTC 
New Package SCM Request
=======================
Package Name: verne-kde-theme
Short Description: Verne KDE Theme
Owners: jreznik rdieter than kkofler ltinkl
Branches: f16
InitialCC:
Comment 4 Gwyn Ciesla 2011-08-01 18:43:13 UTC 
Git done (by process-git-requests).

You really should double-escape the commented macros. (%%).  Also, in the
future, please post at least the complete rpmlint output (including the
dangling symlink warnings, etc), and preferably a more detailed review
generally.  Unless there's a compelling reason that they cannot, the
dangling symlinks should be fixed.  If there is, that should be noted in the
spec.

Thanks!