Bug 727252 - Review Request: verne-kde-theme - Verne KDE Theme
Summary: Review Request: verne-kde-theme - Verne KDE Theme
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Radek Novacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-08-01 16:42 UTC by Jaroslav Reznik
Modified: 2016-12-01 00:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-02 14:40:52 UTC
Type: ---
rnovacek: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jaroslav Reznik 2011-08-01 16:42:46 UTC
Spec URL: http://rezza.hofyland.cz/fedora/packages/verne-kde-theme/verne-kde-theme.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/verne-kde-theme/verne-kde-theme-15.91.0-1.fc14.src.rpm
Description: This is Verne KDE Theme Artwork containing KDM theme,
KSplash theme and Plasma Workspaces theme.

Comment 1 Radek Novacek 2011-08-01 17:28:24 UTC
RPMlint output:
    verne-kde-theme.spec:59: W: macro-in-comment %{buildroot}
    verne-kde-theme.spec:59: W: macro-in-comment %{_kde4_appsdir}
Not an issue.

    verne-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Verne/system-logo-white.png ../../../../../pixmaps/system-logo-white.png
    <same warning few more times>
/usr/share/pixmaps/system-logo-white.png is from package fedora-logos, which provides system-logos required by this package, so not an issue.
    2 packages and 1 specfiles checked; 0 errors, 9 warnings.

Issues:
Typo in the %changelog section: Mon Aug 00 2011


No serious problems found -> setting review+

Comment 2 Jaroslav Reznik 2011-08-01 18:25:54 UTC
Thanks,
changelog fixed. This package is mostly sed s/lovelock/verne to match current wallpaper and we want it to alpha.

Comment 3 Jaroslav Reznik 2011-08-01 18:27:26 UTC
New Package SCM Request
=======================
Package Name: verne-kde-theme
Short Description: Verne KDE Theme
Owners: jreznik rdieter than kkofler ltinkl
Branches: f16
InitialCC:

Comment 4 Gwyn Ciesla 2011-08-01 18:43:13 UTC
Git done (by process-git-requests).

You really should double-escape the commented macros. (%%).  Also, in the
future, please post at least the complete rpmlint output (including the
dangling symlink warnings, etc), and preferably a more detailed review
generally.  Unless there's a compelling reason that they cannot, the
dangling symlinks should be fixed.  If there is, that should be noted in the
spec.

Thanks!


Note You need to log in before you can comment on or make changes to this bug.