Bug 728171

Summary: Review Request: jboss-logging-tools - JBoss Logging I18n Tools
Product: [Fedora] Fedora Reporter: Marek Goldmann <mgoldman>
Component: Package ReviewAssignee: Tomas Radej <tradej>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, tradej
Target Milestone: ---Flags: tradej: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-10 12:11:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 726351    
Bug Blocks: 728202, 728501, 728504, 730314    

Description Marek Goldmann 2011-08-04 09:31:32 UTC
Spec URL: http://goldmann.fedorapeople.org/package_review/jboss-logging-tools/1/jboss-logging-tools.spec
SRPM URL: http://goldmann.fedorapeople.org/package_review/jboss-logging-tools/1/jboss-logging-tools-1.0.0-0.1.Beta7.fc15.src.rpm
Description: JBoss Logging I18n Tools

$ rpmlint ./jboss-logging-tools.spec 
./jboss-logging-tools.spec: W: invalid-url Source0: jboss-logging-tools-1.0.0.Beta7.tar.xz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint ~/rpmbuild/SRPMS/jboss-logging-tools-1.0.0-0.1.Beta7.fc15.src.rpm 
jboss-logging-tools.src: I: enchant-dictionary-not-found en_US
jboss-logging-tools.src: W: invalid-url Source0: jboss-logging-tools-1.0.0.Beta7.tar.xz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Comment 1 Tomas Radej 2011-09-29 10:11:19 UTC
Taking this one.

Comment 2 Tomas Radej 2011-09-29 12:39:46 UTC
Package Review

- = N/A
x = Check
! = Problem
? = Not evaluated

[x]  Rpmlint output: jboss-logging-tools.noarch: W: no-documentation
jboss-logging-tools.src: W: invalid-url Source0: jboss-logging-tools-1.0.0.Beta7.tar.xz
jboss-logging-tools-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other
     legal requirements as defined in the legal section of Packaging
[x]  License field in the package spec file matches the actual license.
     License type: LGPLv2+
[-]  If (and only if) the source package includes the text of the license(s) in
     its own file, then that file, containing the text of the license(s) for the
     package is included in %doc.
[-]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
     in the spec URL.
[x]  All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with
     good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
     (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
[x]  Package contains code, or permissable content.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc
[!]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) << The folder copied is apidocs, should be apidocs/*
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[x]  If package uses tarball from VCS include comment how to re-create that
     tarball (svn export URL, git clone URL, ...)
[-]  If source tarball includes bundled jar/class files these need to be
     removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when
     building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a
[-]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why
     it's needed in a comment
[x]  Package DOES NOT use %update_maven_depmap in %post/%postun
[x]  Packages DOES NOT have Requires(post) and Requires(postun) on
     jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged. << Beta 8 is available, but I suppose it's
     not a blocker

*** ISSUES ***

- Copied folder in javadoc is apidocs, should be apidocs/*

*** NOTES ***

- Version Beta 8 is available

Comment 4 Tomas Radej 2011-10-04 14:03:33 UTC
Looks good.

*** APPROVED ***

Comment 5 Marek Goldmann 2011-10-07 09:07:51 UTC
Thanks for review!

New Package SCM Request
Package Name:      jboss-logging-tools
Short Description: JBoss Logging I18n Tools
Owners:            goldmann

Comment 6 Gwyn Ciesla 2011-10-07 12:22:15 UTC
Git done (by process-git-requests).

Comment 7 Marek Goldmann 2011-10-10 12:11:04 UTC
Thanks for git, closing.