Bug 728202 - Review Request: jboss-msc - JBoss Modular Service Container
Summary: Review Request: jboss-msc - JBoss Modular Service Container
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Tomas Radej
QA Contact: Fedora Extras Quality Assurance
Depends On: 723875 726351 728158 728171 728208
TreeView+ depends on / blocked
Reported: 2011-08-04 11:20 UTC by Marek Goldmann
Modified: 2011-10-19 14:31 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-10-19 14:31:18 UTC
Type: ---
tradej: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
Patch to fix missing dependencies (715 bytes, patch)
2011-10-06 12:46 UTC, Tomas Radej
no flags Details | Diff

Description Marek Goldmann 2011-08-04 11:20:45 UTC
Spec URL: http://goldmann.fedorapeople.org/package_review/jboss-msc/1/jboss-msc.spec
SRPM URL: http://goldmann.fedorapeople.org/package_review/jboss-msc/1/jboss-msc-1.0.0-1.fc15.src.rpm
Description: This package contains the JBoss Modular Service Container.

$ rpmlint ./jboss-msc.spec 
./jboss-msc.spec: W: invalid-url Source0: jboss-msc-1.0.0.GA.tar.xz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint jboss-msc-1.0.0-1.fc15.src.rpm 
jboss-msc.src: I: enchant-dictionary-not-found en_US
jboss-msc.src: W: invalid-url URL: http://www.jboss.org HTTP Error 403: Forbidden
jboss-msc.src: W: invalid-url Source0: jboss-msc-1.0.0.GA.tar.xz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 1 Tomas Radej 2011-10-04 09:50:39 UTC
Taking this one.

Comment 2 Tomas Radej 2011-10-06 12:46:46 UTC
Created attachment 526696 [details]
Patch to fix missing dependencies

Package Review

- = N/A
x = Check
! = Problem
? = Not evaluated

[x]  Rpmlint output: 
jboss-msc.src: W: invalid-url URL: http://www.jboss.org HTTP Error 403: Forbidden
jboss-msc.src: W: invalid-url Source0: jboss-msc-1.0.0.GA.tar.xz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[!]  Package successfully compiles and builds into binary rpms. << Dependencies missing
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other
     legal requirements as defined in the legal section of Packaging
[x]  License field in the package spec file matches the actual license.
     License type: LGPLv2+
[-]  If (and only if) the source package includes the text of the license(s) in
     its own file, then that file, containing the text of the license(s) for the
     package is included in %doc.
[-]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
     in the spec URL.
[!]  All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines[5].
	<< Deps are missing, see Issues
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with
     good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
     (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
[x]  Package contains code, or permissable content.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc
[!]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) 
	<< Folder copied is apidocs, should be apidocs/*
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[x]  If package uses tarball from VCS include comment how to re-create that
     tarball (svn export URL, git clone URL, ...)
[-]  If source tarball includes bundled jar/class files these need to be
     removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when
     building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of
[x]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a
[-]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why
     it's needed in a comment
[x]  Package DOES NOT use %update_maven_depmap in %post/%postun
[x]  Packages DOES NOT have Requires(post) and Requires(postun) on
     jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[!]  Latest version is packaged. << Version 1.0.1.GA is available

*** ISSUES ***
- Javadocs - folder copied is apidocs, should be apidocs/*
- Build dependencies missing: maven-injection-plugin, jboss-modules, apiviz
	<< Apply attached patch

*** NOTES ***
- Version 1.0.1.GA is available upstream
- Does not build due to lack of jboss-thread, jboss-logging tools and
  jboss-vfs. When these packages are pre-installed in mock, builds fine
- Not sure if the empty %doc macro is necessary

Comment 3 Marek Goldmann 2011-10-07 11:34:44 UTC
Thanks for the patch, applied. Packaged 1.0.1.GA, removed empty doc macro and fixed the apidocs.

Spec URL:

Comment 4 Tomas Radej 2011-10-10 08:40:26 UTC
Sorry, but the source RPM seems not to be on the specified address. Could you, please, correct it? Thank you.

Comment 5 Marek Goldmann 2011-10-10 10:33:11 UTC
Tomas, you are right, I put correct packages under above links.

Comment 6 Tomas Radej 2011-10-19 13:23:40 UTC
Sorry it took so long.

*** APPROVED ***

Comment 7 Marek Goldmann 2011-10-19 13:40:33 UTC
Thanks for review!

New Package SCM Request
Package Name:      jboss-msc
Short Description: JBoss Modular Service Container
Owners:            goldmann

Comment 8 Gwyn Ciesla 2011-10-19 13:50:22 UTC
Git done (by process-git-requests).

Comment 9 Marek Goldmann 2011-10-19 14:31:18 UTC
Thanks for git, closing.

Note You need to log in before you can comment on or make changes to this bug.