Bug 729292

Summary: Not releasing IPv6 leases - wrong PID file name.
Product: [Fedora] Fedora Reporter: DaveG <daveg>
Component: initscriptsAssignee: Bill Nottingham <notting>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 14CC: iarlyy, jonathan, notting, plautrba, rvokal
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 729359 (view as bug list) Environment:
Last Closed: 2012-02-09 21:10:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 729359    

Description DaveG 2011-08-09 11:50:57 UTC
Description of problem:
While experimenting with IPv6, DHCP & DDNS, I noticed a typo in /etc/sysconfig/network-scripts/ifdown-eth.
In the stanza handling dhclient shutdown (line 73) the PID file name passed to dhclient does not include the IP version prefix. IPv4 is closed first, removing it's PID file, then IPv6 is closed using the (now removed) IPv4 PID file.

Version-Release number of selected component (if applicable):
initscripts-9.20.2-1.fc14.1.x86_64

How reproducible:

Steps to Reproduce:
1.
2.
3.
  
Actual results:
/sbin/dhclient -r -lf /var/lib/dhclient/dhclient$VER-${DEVICE}.leases -pf /var/run/dhclient-${DEVICE}.pid ${DEVICE} >/dev/null 2>&1

Expected results:
/sbin/dhclient -r -lf /var/lib/dhclient/dhclient$VER-${DEVICE}.leases -pf /var/run/dhclient$VER-${DEVICE}.pid ${DEVICE} >/dev/null 2>&1

Additional info:
Quick diff -u:
--- ifdown-eth.daveg	2011-02-25 20:23:36.000000000 +0000
+++ ifdown-eth	2011-08-09 12:41:23.747160554 +0100
@@ -70,7 +70,7 @@
 	if [ -f "/var/run/dhclient$VER-${DEVICE}.pid" ]; then
 		dhcpid=$(cat /var/run/dhclient$VER-${DEVICE}.pid)
 		if [[ "$DHCPRELEASE" = [yY1]* ]];  then
-			/sbin/dhclient -r -lf /var/lib/dhclient/dhclient$VER-${DEVICE}.leases -pf /var/run/dhclient-${DEVICE}.pid ${DEVICE} >/dev/null 2>&1
+			/sbin/dhclient -r -lf /var/lib/dhclient/dhclient$VER-${DEVICE}.leases -pf /var/run/dhclient$VER-${DEVICE}.pid ${DEVICE} >/dev/null 2>&1
 			retcode=$?
 		else
 			kill $dhcpid >/dev/null 2>&1

--DaveG.

Comment 1 Bill Nottingham 2011-08-09 16:32:45 UTC
Thanks for the patch! Added to rawhide, F-15, and F-14 branches, will be in some future update.