Bug 729961

Summary:	add the pt and zh locales to coregui
Product:	[Other] RHQ Project	Reporter:	Heiko W. Rupp <hrupp>
Component:	Build System	Assignee:	Ian Springer <ian.springer>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	high	Docs Contact:
Priority:	medium
Version:	4.1	CC:	ccrouch, hrupp, ian.springer
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-07 19:27:00 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	729848, 730796

Description Heiko W. Rupp 2011-08-11 12:05:35 UTC

Current 4.1.0 beta build is missing pt and zh translations, as they seem to not be enabled in settings.xml

We should find out how those builds can automatically include all locales without the need to manually tune settings.xml - perhaps by specifying no locales at all .

If this fails, we need a very simple process + readme on how to add new locales.

Comment 1 Ian Springer 2011-08-16 18:24:49 UTC

I've added the pt and zh locales with [master 3c15c6f]. The process is actually very simple - just add the locales to the gwt.locale property in coregui/pom.xml. Here's what that property looks like after my update:

        <!-- Comma-separated list of the locales that should be included during GWT compilation. The specified locales
             should each have two corresponding message bundle properties files under
             src/main/resources/org/rhq/enterprise/gui/coregui/client/. For example, the "ja" locale has
             Messages_ja.properties and MessageConstants_ja.properties. -->
        <gwt.locale>en,de,ja,pt,zh</gwt.locale>

Note, if you don't want building coregui on your local machine to take 15 minutes, make sure to add something like the following in the properties section of an active profile in your ~/.m2/settings.xml:

        <!-- Only compile the default locale. -->
        <gwt.locale>default</gwt.locale>

Comment 2 Mike Foley 2011-08-17 12:40:45 UTC

documenting verification steps:

http://localhost:7080/coregui/CoreGUI.html?locale=de
http://localhost:7080/coregui/CoreGUI.html?locale=ja

Comment 3 Mike Foley 2011-08-17 17:29:38 UTC

verified build 8/17 by visiting these URLs and seeing the correct language:

http://localhost:7080/coregui/CoreGUI.html?locale=de
http://localhost:7080/coregui/CoreGUI.html?locale=ja

Comment 4 Ian Springer 2011-08-17 17:44:51 UTC

Shouldn't those URLs instead be:

http://localhost:7080/coregui/CoreGUI.html?locale=pt
http://localhost:7080/coregui/CoreGUI.html?locale=zh

Comment 5 Heiko W. Rupp 2011-08-18 07:26:13 UTC

All of comment 3 and comment 4 !

Comment 6 Mike Foley 2012-02-07 19:27:00 UTC

changing status of VERIFIED BZs for JON 2.4.2 and JON 3.0 to CLOSED/CURRENTRELEASE