Bug 730324
| Summary: | Review Request: telepathy-kde-accounts-kcm-plugins - Plugins for protocol-specific UI's in the Telepathy Accounts KCM | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Radek Novacek <rnovacek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, ovasik, package-review, rnovacek |
| Target Milestone: | --- | Flags: | rnovacek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-09-18 17:39:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 723123, 730323 | ||
| Bug Blocks: | 656997 | ||
|
Description
Rex Dieter
2011-08-12 13:49:54 UTC
Name: ok License: wrong, spec says GPLv2+, source is LGPLv2+ Source: wrong URL, should be http://download.kde.org/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2 instead of http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2 BRs/Reqs: BuildRequires: desktop-file-utils present but no desktop-file-* used Macros used consistently: ok ldconfig: not needed Desktop file validations: not needed Docs: commented out, why? Devel: NA Files: ok Build: ok rpmlint: telepathy-kde-accounts-kcm-plugins.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4) Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-accounts-kcm-plugins.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-accounts-kcm-plugins-0.1.0-2.fc15.src.rpm %changelog * Wed Sep 14 2011 Rex Dieter <rdieter> 0.1.0-2 - %doc COPYING README - fix Source URL - fix mixed spaces/tabs Fix the license too, please. Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-accounts-kcm-plugins.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-accounts-kcm-plugins-0.1.0-3.fc15.src.rpm %changelog * Thu Sep 15 2011 Rex Dieter <rdieter> 0.1.0-3 - License: LGPLv2+ Thanks for fixing the issues, setting fedora-review+. New Package SCM Request ======================= Package Name: telepathy-kde-accounts-kcm-plugins Short Description: Plugins for protocol-specific UI's in the Telepathy Accounts KCM Owners: jreznik rdieter Branches: f15 f16 Git done (by process-git-requests). imported |