Bug 730324 - Review Request: telepathy-kde-accounts-kcm-plugins - Plugins for protocol-specific UI's in the Telepathy Accounts KCM
Summary: Review Request: telepathy-kde-accounts-kcm-plugins - Plugins for protocol-spe...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Radek Novacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: telepathy-qt4 730323
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-08-12 13:49 UTC by Rex Dieter
Modified: 2016-12-01 00:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-18 17:39:10 UTC
rnovacek: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Radek Novacek 2011-09-12 12:22:34 UTC
Name: ok
License: wrong, spec says GPLv2+, source is LGPLv2+
Source: wrong URL, should be
http://download.kde.org/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2
instead of
http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2
BRs/Reqs: BuildRequires: desktop-file-utils present but no desktop-file-* used
Macros used consistently: ok
ldconfig: not needed
Desktop file validations: not needed
Docs: commented out, why?
Devel: NA
Files: ok
Build: ok
rpmlint: 
telepathy-kde-accounts-kcm-plugins.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4)

Comment 2 Rex Dieter 2011-09-14 19:25:49 UTC
Spec URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-accounts-kcm-plugins.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-accounts-kcm-plugins-0.1.0-2.fc15.src.rpm

%changelog
* Wed Sep 14 2011 Rex Dieter <rdieter@fedoraproject.org> 0.1.0-2
- %doc COPYING README
- fix Source URL
- fix mixed spaces/tabs

Comment 3 Radek Novacek 2011-09-15 07:02:15 UTC
Fix the license too, please.

Comment 5 Radek Novacek 2011-09-16 06:24:38 UTC
Thanks for fixing the issues, setting fedora-review+.

Comment 6 Rex Dieter 2011-09-16 14:35:56 UTC
New Package SCM Request
=======================
Package Name: telepathy-kde-accounts-kcm-plugins
Short Description: Plugins for protocol-specific UI's in the Telepathy Accounts KCM
Owners: jreznik rdieter
Branches: f15 f16

Comment 7 Gwyn Ciesla 2011-09-17 01:58:20 UTC
Git done (by process-git-requests).

Comment 8 Rex Dieter 2011-09-18 17:39:10 UTC
imported


Note You need to log in before you can comment on or make changes to this bug.