Bug 730749

Summary: problem with /distribution/virt/install workaround.
Product: [Retired] Beaker Reporter: Gurhan Ozen <gozen>
Component: testsAssignee: Gurhan Ozen <gozen>
Status: CLOSED CURRENTRELEASE QA Contact: Gurhan Ozen <gozen>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 0.5CC: bpeck, dcallagh, jburke, mcsontos, rmancy, stl
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-29 16:37:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Gurhan Ozen 2011-08-15 16:00:15 UTC 
Description of problem:
From the email:

"
Hello,

I just noticed that our old virt reserving xml failed at
/distribution/virt/install:

https://beaker.engineering.redhat.com/jobs/119202

And if I try to comment out the workaround for bz729608, it works again,
at least not at "ERROR (cli:283) Need to pass size for each disk":

https://beaker.engineering.redhat.com/jobs/119253

I notice that though we had already passed '--file ...' to the script,
it still added another '--file ...' in the command for virt-install. I
cannot figure out why is this. I guess maybe this line:

 echo ${CMDLINE} | awk '{rc=0; for(i=1;i<=NF;i++) { if ( $i ~ /--disk*/ # || $i ~ /--file=/ || $i == "--file" ) rc+=1; } exit rc }'

should be written as

 echo ${CMDLINE} | awk 'BEGIN {rc=0} ; { for(i=1;i<=NF;i++) { if ( $i ~ /--disk*/ || $i ~ /--file=/ || $i == "--file" ) rc+=1 }}; END { exit rc; }'

Because it looks like the CMDLINE was echoed as multi-lines.

Please have a look. Thanks in advance.
"

Version-Release number of selected component (if applicable):


How reproducible:
Very

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Gurhan Ozen 2011-10-29 16:16:31 UTC 
fixed long time ago.