Bug 733053
| Summary: | Review Request: perl-Unicode-CheckUTF8 - Checks if scalar is valid UTF-8 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
| Component: | Package Review | Assignee: | Mario Blättermann <mario.blaettermann> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mario.blaettermann, notting, package-review |
| Target Milestone: | --- | Flags: | mario.blaettermann:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Unicode-CheckUTF8-1.03-2.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-10-03 15:18:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Paul Howarth
2011-08-24 15:19:48 UTC
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3307770 $ rpmlint -i -v * perl-Unicode-CheckUTF8.i686: I: checking perl-Unicode-CheckUTF8.i686: I: checking-url http://search.cpan.org/dist/Unicode-String/ (timeout 10 seconds) perl-Unicode-CheckUTF8.src: I: checking perl-Unicode-CheckUTF8.src: I: checking-url http://search.cpan.org/dist/Unicode-String/ (timeout 10 seconds) perl-Unicode-CheckUTF8.src: E: unknown-key GPG#b56a8bac The package was signed, but with an unknown key. See the rpm --import option for more information. perl-Unicode-CheckUTF8.src: I: checking-url http://search.cpan.org/CPAN/authors/id/B/BR/BRADFITZ/Unicode-CheckUTF8-1.03.tar.gz (timeout 10 seconds) perl-Unicode-CheckUTF8.x86_64: I: checking perl-Unicode-CheckUTF8.x86_64: I: checking-url http://search.cpan.org/dist/Unicode-String/ (timeout 10 seconds) perl-Unicode-CheckUTF8-debuginfo.i686: I: checking perl-Unicode-CheckUTF8-debuginfo.i686: I: checking-url http://search.cpan.org/dist/Unicode-String/ (timeout 10 seconds) perl-Unicode-CheckUTF8-debuginfo.x86_64: I: checking perl-Unicode-CheckUTF8-debuginfo.x86_64: I: checking-url http://search.cpan.org/dist/Unicode-String/ (timeout 10 seconds) /home/mariobl/Arbeitsfläche/perl-Unicode-CheckUTF8/perl-Unicode-CheckUTF8-1.03-2.fc17.src/perl-Unicode-CheckUTF8.spec: I: checking-url http://search.cpan.org/CPAN/authors/id/B/BR/BRADFITZ/Unicode-CheckUTF8-1.03.tar.gz (timeout 10 seconds) 5 packages and 1 specfiles checked; 1 errors, 0 warnings. The srpm has been signed, probably unintended... No further issues. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. UCD, GPL+ or Artistic [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum *86e8e76883e4ef96820f893aab6ccdca perl-Unicode-CheckUTF8.spec a483f665b2bc62d7737c209294e64e1e Unicode-CheckUTF8-1.03.tar.gz a483f665b2bc62d7737c209294e64e1e Unicode-CheckUTF8-1.03.tar.gz.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. Don't know how to test it on my system. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [+] SHOULD: Your package should contain man pages for binaries/scripts. ---------------- PACKAGE APPROVED ---------------- New Package SCM Request ======================= Package Name: perl-Unicode-CheckUTF8 Short Description: Checks if scalar is valid UTF-8 Owners: pghmcfc Branches: EL-4 EL-5 EL-6 F-14 F-15 F-16 InitialCC: perl-sig Git done (by process-git-requests). perl-Unicode-CheckUTF8-1.03-2.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Unicode-CheckUTF8-1.03-2.el4 perl-Unicode-CheckUTF8-1.03-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Unicode-CheckUTF8-1.03-2.el5 perl-Unicode-CheckUTF8-1.03-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Unicode-CheckUTF8-1.03-2.fc15 perl-Unicode-CheckUTF8-1.03-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Unicode-CheckUTF8-1.03-2.fc14 perl-Unicode-CheckUTF8-1.03-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Unicode-CheckUTF8-1.03-2.fc16 perl-Unicode-CheckUTF8-1.03-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Unicode-CheckUTF8-1.03-2.el6 perl-Unicode-CheckUTF8-1.03-2.fc15 has been pushed to the Fedora 15 stable repository. perl-Unicode-CheckUTF8-1.03-2.fc14 has been pushed to the Fedora 14 stable repository. perl-Unicode-CheckUTF8-1.03-2.el6 has been pushed to the Fedora EPEL 6 stable repository. perl-Unicode-CheckUTF8-1.03-2.el4 has been pushed to the Fedora EPEL 4 stable repository. perl-Unicode-CheckUTF8-1.03-2.el5 has been pushed to the Fedora EPEL 5 stable repository. perl-Unicode-CheckUTF8-1.03-2.fc16 has been pushed to the Fedora 16 stable repository. Package is now available for all currently-supported releases. |