Bug 735181

Summary: calibre doesn't build with poppler-0.17.3
Product: [Fedora] Fedora Reporter: Marek Kašík <mkasik>
Component: calibreAssignee: Kevin Fenzi <kevin>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: chkr, kevin, mbacovsk, nushio, sysoutfran
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-09-09 19:27:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 735175    
Attachments:
Description Flags
make calibre build with poppler-0.17.3 none

Description Marek Kašík 2011-09-01 17:38:10 UTC 
Description of problem:
Current version of calibre needs poppler's class DCTStream, which is not present now.


Log snippet:
/builddir/build/BUILD/calibre/src/calibre/ebooks/pdf/images.cpp: In member function 'void calibre_reflow::XMLImages::add(GfxState*, Object*, Stream*, unsigned int, unsigned int, GfxImageColorMap*, bool, int*, bool)':
/builddir/build/BUILD/calibre/src/calibre/ebooks/pdf/images.cpp:129:17: error: 'DCTStream' was not declared in this scope
/builddir/build/BUILD/calibre/src/calibre/ebooks/pdf/images.cpp:129:28: error: expected primary-expression before ')' token
/builddir/build/BUILD/calibre/src/calibre/ebooks/pdf/images.cpp:129:29: error: expected ')' before 'str'


Version-Release number of selected component (if applicable):
calibre-0.8.11-2


Actual results:
Build fails.


Expected results:
Build succeed.


Additional info:
See the bug #735175 for more info and scratch-build of poppler-0.17.3.
This was introduced by upstream commit "Sanitize headers a big" (mainly by correction of definition of ENABLE_LIBJPEG - see definition of DCTStream class in poppler/Stream.h)
Comment 1 Marek Kašík 2011-09-09 12:20:31 UTC 
Created attachment 522322 [details]
make calibre build with poppler-0.17.3

Hi,

I've prepared a patch based on the one created by Caolan for bug #735182. Calibre builds well with it.
Btw, you can update BuildRequires to require poppler-qt-devel since poppler doesn't contain poppler-qt4-devel subpackage now.

Regards

Marek
Comment 2 Kevin Fenzi 2011-09-09 19:27:42 UTC 
Applied. Thanks!

If you want commit access to apply things like these, feel free to apply.