Bug 735181 - calibre doesn't build with poppler-0.17.3
Summary: calibre doesn't build with poppler-0.17.3
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: calibre
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 735175
TreeView+ depends on / blocked
 
Reported: 2011-09-01 17:38 UTC by Marek Kašík
Modified: 2011-09-09 19:27 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-09 19:27:42 UTC

Attachments (Terms of Use)
make calibre build with poppler-0.17.3 (803 bytes, patch)
2011-09-09 12:20 UTC, Marek Kašík 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Description Marek Kašík 2011-09-01 17:38:10 UTC 
Description of problem:
Current version of calibre needs poppler's class DCTStream, which is not present now.


Log snippet:
/builddir/build/BUILD/calibre/src/calibre/ebooks/pdf/images.cpp: In member function 'void calibre_reflow::XMLImages::add(GfxState*, Object*, Stream*, unsigned int, unsigned int, GfxImageColorMap*, bool, int*, bool)':
/builddir/build/BUILD/calibre/src/calibre/ebooks/pdf/images.cpp:129:17: error: 'DCTStream' was not declared in this scope
/builddir/build/BUILD/calibre/src/calibre/ebooks/pdf/images.cpp:129:28: error: expected primary-expression before ')' token
/builddir/build/BUILD/calibre/src/calibre/ebooks/pdf/images.cpp:129:29: error: expected ')' before 'str'


Version-Release number of selected component (if applicable):
calibre-0.8.11-2


Actual results:
Build fails.


Expected results:
Build succeed.


Additional info:
See the bug #735175 for more info and scratch-build of poppler-0.17.3.
This was introduced by upstream commit "Sanitize headers a big" (mainly by correction of definition of ENABLE_LIBJPEG - see definition of DCTStream class in poppler/Stream.h)
Comment 1 Marek Kašík 2011-09-09 12:20:31 UTC 
Created attachment 522322 [details]
make calibre build with poppler-0.17.3

Hi,

I've prepared a patch based on the one created by Caolan for bug #735182. Calibre builds well with it.
Btw, you can update BuildRequires to require poppler-qt-devel since poppler doesn't contain poppler-qt4-devel subpackage now.

Regards

Marek
Comment 2 Kevin Fenzi 2011-09-09 19:27:42 UTC 
Applied. Thanks!

If you want commit access to apply things like these, feel free to apply.
Note You need to log in before you can comment on or make changes to this bug.