Bug 736582 (ghc-primitive)
| Summary: | Review Request: ghc-primitive - Wrappers for primitive operations | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | haskell-devel, michel, notting, package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
petersen: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ghc-vector-0.7.1-1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-09-27 23:02:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 736586 | ||
|
Description
Jens Petersen
2011-09-08 07:29:39 UTC
Any reason 0.3.1 is packaged, instead of 0.4.0.1 ? (not that it'd affect the review; will post result shortly) Packaging looks fine, APPROVED
* TODO Review [100%]
- [X] Names [2/2]
- [X] Package name
- [X] Spec name
- [X] Package version [2/2]
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning
- [X] Version number
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag
- [X] Release tag
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
- [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
- [X] Source files match upstream
- [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]]
- [X] License [4/4]
- [X] License is Fedora-approved
- [X] No licensing conflict
- [X] License field accurate
- [X] License included iff packaged by upstream
- [X] rpmlint [2/2]
- [X] on src.rpm
$ rpmlint ./ghc-primitive-0.3.1-1.fc17.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint ./ghc-primitive-0.3.1-1.fc15.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
- [X] on x86_64.rpm
$ rpmlint ./ghc-primitive-*.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
- [X] Language & locale [2/2]
- [X] Spec in US English
- [X] Spec legible
- [X] Build [3/3]
- [X] Koji results
- [X] BRs complete
- [X] Directory ownership
- [X] Spec inspection [7/7]
- [X] No duplicate files
- [X] File permissions
- [X] Filenames must be UTF-8
- [X] no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting RHEL5]])
- [X] Macro usage consistent
- [X] Documentation [1/1]
- [X] %doc files are non-essential
- [X] Development [2/2]
- [X] Headers in -devel
- [X] -devel, -static requires main
Thank you for the reviewing already. :-) (In reply to comment #1) > Any reason 0.3.1 is packaged, instead of 0.4.0.1 ? (not that it'd affect the > review; will post result shortly) Yes, good question forgot to comment about that here: that is intentional since snap-core needs vector < 0.8 which in turns needs primitive < 0.4. New Package SCM Request ======================= Package Name: ghc-primitive Short Description: Wrappers for primitive operations Owners: petersen Branches: f16 f15 f14 el6 InitialCC: haskell-sig Git done (by process-git-requests). ghc-vector-0.7.1-1.fc16,ghc-primitive-0.3.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ghc-vector-0.7.1-1.fc16,ghc-primitive-0.3.1-1.fc16 ghc-vector-0.7.1-1.fc16, ghc-primitive-0.3.1-1.fc16 has been pushed to the Fedora 16 testing repository. ghc-vector-0.7.1-1.fc15,ghc-primitive-0.3.1-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-vector-0.7.1-1.fc15,ghc-primitive-0.3.1-2.fc15 ghc-vector-0.7.1-1.fc14,ghc-primitive-0.3.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-vector-0.7.1-1.fc14,ghc-primitive-0.3.1-2.fc14 ghc-vector-0.7.1-1.fc14, ghc-primitive-0.3.1-2.fc14 has been pushed to the Fedora 14 testing repository. ghc-vector-0.7.1-1.fc15, ghc-primitive-0.3.1-2.fc15 has been pushed to the Fedora 15 stable repository. ghc-vector-0.7.1-1.fc14, ghc-primitive-0.3.1-2.fc14 has been pushed to the Fedora 14 stable repository. ghc-vector-0.7.1-1.fc16, ghc-primitive-0.3.1-2.fc16 has been pushed to the Fedora 16 stable repository. ghc-primitive-0.4.0.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ghc-primitive-0.4.0.1-1.el6 ghc-primitive-0.4.0.1-1.el6, ghc-vector-0.9.1-7.el6 has been pushed to the Fedora EPEL 6 stable repository. Package Change Request ====================== Package Name: ghc-primitive New Branches: el5 Owners: petersen InitialCC: haskell-sig Git done (by process-git-requests). |