Red Hat Bugzilla – Bug 736586
Review Request: ghc-vector - Efficient Arrays for Haskell
Last modified: 2014-01-02 06:34:24 EST
Spec URL: http://petersen.fedorapeople.org/reviews/ghc-vector/ghc-vector.spec
SRPM URL: http://petersen.fedorapeople.org/reviews/ghc-vector/ghc-vector-0.7.1-1.fc15.src.rpm
An efficient implementation of Int-indexed arrays (both mutable and immutable), with a powerful loop fusion optimization framework.
vector has well over a hundred reverse deps in hackage:
0.7.* still seems the most popular version and is also required currently by snap.
Packaging looks fine; approved (no Koji result as the dependency is not in Rawhide yet)
* TODO Review [100%]
- [X] Names [2/2]
- [X] Package name
- [X] Spec name
- [X] Package version [2/2]
- [X] Version number
- [X] Release tag
- [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
- [X] Source files match upstream
$ sha1sum ./vector-0.7.1.tar.gz ../SOURCES/vector-0.7.1.tar.gz
- [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]]
- [X] License [4/4]
- [X] License is Fedora-approved
- [X] No licensing conflict
- [X] License field accurate
- [X] License included iff packaged by upstream
- [X] rpmlint [2/2]
- [X] on src.rpm
$ rpmlint ./ghc-vector-0.7.1-1.fc15.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
- [X] on x86_64.rpm
$ rpmlint ../RPMS/x86_64/ghc-vector-*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
- [X] Language & locale [2/2]
- [X] Spec in US English
- [X] Spec legible
- [X] Build [2/2]
- [X] BRs complete
- [X] Directory ownership
- [X] Spec inspection [7/7]
- [X] No duplicate files
- [X] File permissions
- [X] Filenames must be UTF-8
- [X] no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting RHEL5]])
- [X] Macro usage consistent
- [X] Documentation [1/1]
- [X] %doc files are non-essential
- [X] Development [2/2]
- [X] Headers in -devel
- [X] -devel, -static requires main
Thank you very much for reviewing. :)
New Package SCM Request
Package Name: ghc-vector
Short Description: Efficient arrays for Haskell
Branches: f16 f15 f14 el6
Git done (by process-git-requests).
ghc-vector-0.7.1-1.fc16,ghc-primitive-0.3.1-1.fc16 has been submitted as an update for Fedora 16.
ghc-vector-0.7.1-1.fc16, ghc-primitive-0.3.1-1.fc16 has been pushed to the Fedora 16 testing repository.
ghc-vector-0.7.1-1.fc15,ghc-primitive-0.3.1-2.fc15 has been submitted as an update for Fedora 15.
ghc-vector-0.7.1-1.fc14,ghc-primitive-0.3.1-2.fc14 has been submitted as an update for Fedora 14.
ghc-vector-0.7.1-1.fc14, ghc-primitive-0.3.1-2.fc14 has been pushed to the Fedora 14 testing repository.
ghc-vector-0.7.1-1.fc15, ghc-primitive-0.3.1-2.fc15 has been pushed to the Fedora 15 stable repository.
ghc-vector-0.7.1-1.fc14, ghc-primitive-0.3.1-2.fc14 has been pushed to the Fedora 14 stable repository.
ghc-vector-0.7.1-1.fc16, ghc-primitive-0.3.1-2.fc16 has been pushed to the Fedora 16 stable repository.
ghc-primitive-0.4.0.1-1.el6, ghc-vector-0.9.1-7.el6 has been submitted as an update for Fedora EPEL 6.
ghc-primitive-0.4.0.1-1.el6, ghc-vector-0.9.1-7.el6 has been pushed to the Fedora EPEL 6 stable repository.
Package Change Request
Package Name: ghc-vector
New Branches: el5