Bug 737385

Summary: [PATCH] Sync FFLAGS and LDFLAGS in the %cmake macro with redhat-rpm-config
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: cmakeAssignee: Orion Poplawski <orion>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jreznik, orion, pertusus, rdieter
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-09-13 21:57:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Sync FFLAGS and LDFLAGS in the %cmake macro with redhat-rpm-config none

Description Ville Skyttä 2011-09-11 17:50:18 UTC 
Created attachment 522615 [details]
Sync FFLAGS and LDFLAGS in the %cmake macro with redhat-rpm-config

The attached patch syncs %cmake's FFLAGS and LDFLAGS with redhat-rpm-config's %configure macro:

redhat-rpm-config's %configure adds -I%_fmoddir to FFLAGS and defines %_fmoddir.  After this patch, %cmake adds it as well if %_fmoddir is defined.

Similarly, redhat-rpm-config defines LDFLAGS via %__global_ldflags; after this patch %cmake defines LDFLAGS as well if %__global_ldflags is defined.  More background info: http://lists.fedoraproject.org/pipermail/devel/2011-August/155358.html
Comment 1 Orion Poplawski 2011-09-13 21:57:35 UTC 
Thanks.  Applied.  One wonders if these shouldn't be encapsulated in some kind of %set_flags macro.