Bug 737385 - [PATCH] Sync FFLAGS and LDFLAGS in the %cmake macro with redhat-rpm-config
Summary: [PATCH] Sync FFLAGS and LDFLAGS in the %cmake macro with redhat-rpm-config
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: cmake
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-09-11 17:50 UTC by Ville Skyttä
Modified: 2011-09-13 21:57 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-13 21:57:35 UTC


Attachments (Terms of Use)
Sync FFLAGS and LDFLAGS in the %cmake macro with redhat-rpm-config (1.58 KB, patch)
2011-09-11 17:50 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2011-09-11 17:50:18 UTC
Created attachment 522615 [details]
Sync FFLAGS and LDFLAGS in the %cmake macro with redhat-rpm-config

The attached patch syncs %cmake's FFLAGS and LDFLAGS with redhat-rpm-config's %configure macro:

redhat-rpm-config's %configure adds -I%_fmoddir to FFLAGS and defines %_fmoddir.  After this patch, %cmake adds it as well if %_fmoddir is defined.

Similarly, redhat-rpm-config defines LDFLAGS via %__global_ldflags; after this patch %cmake defines LDFLAGS as well if %__global_ldflags is defined.  More background info: http://lists.fedoraproject.org/pipermail/devel/2011-August/155358.html

Comment 1 Orion Poplawski 2011-09-13 21:57:35 UTC
Thanks.  Applied.  One wonders if these shouldn't be encapsulated in some kind of %set_flags macro.


Note You need to log in before you can comment on or make changes to this bug.