Bug 739644

Summary: espeak 1.45.05-2 not built with $RPM_OPT_FLAGS
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: espeakAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jskarvad, kparal, pbrobinson
Target Milestone: ---Keywords: Patch, Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-09-19 18:40:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 496968    
Attachments:
Description Flags
Build with $RPM_OPT_FLAGS and $RPM_LD_FLAGS none

Description Ville Skyttä 2011-09-19 17:35:43 UTC
Created attachment 523877 [details]
Build with $RPM_OPT_FLAGS and $RPM_LD_FLAGS

espeak 1.45.05-2 is not built with $RPM_OPT_FLAGS; 1.43-4 did not have this problem.

http://kojipkgs.fedoraproject.org/packages/espeak/1.45.05/2.fc17/data/logs/x86_64/build.log

Fix attached.  Regarding $RPM_LD_FLAGS this patch adds "while at it", see http://lists.fedoraproject.org/pipermail/devel/2011-August/155358.html

Comment 1 Jaroslav Škarvada 2011-09-19 18:40:43 UTC
Ville thanks, applied.

Kamil, such regressions could be caught automatically, couldn't it?
http://autoqa.fedoraproject.org/results/194309-autotest/qa06.qa.fedoraproject.org/depcheck/results/espeak-1.45.05-1.fc1.html

Comment 2 Ville Skyttä 2011-09-19 19:32:05 UTC
I have submitted the script I use to look for problems like this (and which in fact caught this one) to AutoQA about 2 years ago but not much has happened: https://fedorahosted.org/autoqa/ticket/59

Also, rpmlint has issued errors for empty debuginfo packages and ones without sources for a long time, those too would have caught this one.

Comment 3 Kamil Páral 2011-09-19 20:13:05 UTC
Unfortunately we currently don't have resources to execute these tests. Loads of new proposed test cases, unfinished software architecture and scarce development power. Very sorry :-/