Bug 739644 - espeak 1.45.05-2 not built with $RPM_OPT_FLAGS
Summary: espeak 1.45.05-2 not built with $RPM_OPT_FLAGS
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: espeak
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jaroslav Škarvada
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DebugInfo
TreeView+ depends on / blocked
 
Reported: 2011-09-19 17:35 UTC by Ville Skyttä
Modified: 2011-09-19 20:13 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-09-19 18:40:43 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Build with $RPM_OPT_FLAGS and $RPM_LD_FLAGS (1.22 KB, patch)
2011-09-19 17:35 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2011-09-19 17:35:43 UTC
Created attachment 523877 [details]
Build with $RPM_OPT_FLAGS and $RPM_LD_FLAGS

espeak 1.45.05-2 is not built with $RPM_OPT_FLAGS; 1.43-4 did not have this problem.

http://kojipkgs.fedoraproject.org/packages/espeak/1.45.05/2.fc17/data/logs/x86_64/build.log

Fix attached.  Regarding $RPM_LD_FLAGS this patch adds "while at it", see http://lists.fedoraproject.org/pipermail/devel/2011-August/155358.html

Comment 1 Jaroslav Škarvada 2011-09-19 18:40:43 UTC
Ville thanks, applied.

Kamil, such regressions could be caught automatically, couldn't it?
http://autoqa.fedoraproject.org/results/194309-autotest/qa06.qa.fedoraproject.org/depcheck/results/espeak-1.45.05-1.fc1.html

Comment 2 Ville Skyttä 2011-09-19 19:32:05 UTC
I have submitted the script I use to look for problems like this (and which in fact caught this one) to AutoQA about 2 years ago but not much has happened: https://fedorahosted.org/autoqa/ticket/59

Also, rpmlint has issued errors for empty debuginfo packages and ones without sources for a long time, those too would have caught this one.

Comment 3 Kamil Páral 2011-09-19 20:13:05 UTC
Unfortunately we currently don't have resources to execute these tests. Loads of new proposed test cases, unfinished software architecture and scarce development power. Very sorry :-/


Note You need to log in before you can comment on or make changes to this bug.