Bug 740753

Summary: NM won't setup IBFT card
Product: [Fedora] Fedora Reporter: Ales Kozumplik <akozumpl>
Component: NetworkManagerAssignee: Dan Williams <dcbw>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: dcbw, jklimes, jzeleny, rvykydal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-0.9.1.90-3.git20110927.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-09-29 23:30:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 736893    
Attachments:
Description Flags
/tmp/syslog
none
Proposed patch to fix the iscsiadm patch none

Description Ales Kozumplik 2011-09-23 08:40:54 UTC
Created attachment 524562 [details]
/tmp/syslog

I can reproduce this in Anaconda in F16-Beta-TC2, an Intel IBFT card setup to use dhcp simply won't come up. This appears in the logs right after the failed attempt:

08:14:31,0 INFO NetworkManager: <info> (p3p1): now managed
08:14:31,0 INFO NetworkManager: <info> (p3p1): device state change: unmanaged -> unavailable (reason 'managed') [10 20 2
]
08:14:31,0 INFO NetworkManager: <info> (p3p1): preparing device.
08:14:31,0 INFO NetworkManager: <info> (p3p1): deactivating device (reason: 2).
08:14:31,0 INFO NetworkManager: <info> (p3p1): device state change: unavailable -> disconnected (reason 'none') [20 30 0
]
08:14:39,699 DEBUG kernel:[   26.754027] p3p1: no IPv6 routers present
08:15:55,0 NOTICE NetworkManager:    ifcfg-rh: removed /etc/sysconfig/network-scripts/ifcfg-p3p1.
08:15:55,0 NOTICE NetworkManager:    ifcfg-rh: parsing /etc/sysconfig/network-scripts/ifcfg-p3p1 ... 
08:15:55,0 NOTICE NetworkManager:    ifcfg-rh:     error: Failed to execute child process "/usr/sbin/iscsiadm" (No such 
file or directory)
08:15:55,0 NOTICE NetworkManager:    ifcfg-rh: parsing /etc/sysconfig/network-scripts/ifcfg-p3p1 ... 
08:15:55,0 NOTICE NetworkManager:    ifcfg-rh:     error: Failed to execute child process "/usr/sbin/iscsiadm" (No such 
file or directory)
08:16:37,0 NOTICE NetworkManager:    ifcfg-rh: parsing /etc/sysconfig/network-scripts/ifcfg-p3p1 ... 
08:16:37,0 NOTICE NetworkManager:    ifcfg-rh:     error: Failed to execute child process "/usr/sbin/iscsiadm" (No such 
file or directory)

Attaching the full log, note that Anaconda eventually establishes the connection through dhcp, but that is suboptimal (since it takes some clicking and some failed attempts).

Comment 1 Ales Kozumplik 2011-09-23 10:12:05 UTC
As far as I know, iscsiadm has always been at /sbin/iscsiadm.

Comment 2 Jirka Klimes 2011-09-26 08:21:59 UTC
We use sbindir as the path for iscsiadm.

After checking build log for the package,
http://kojipkgs.fedoraproject.org/packages/NetworkManager/0.8.3.998/1.fc14/data/logs/x86_64/build.log, it appears that sbin is /usr/sbin :

./configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc .....

%_sbindir is defined as %{_exec_prefix}/sbin and 
%_exec_prefix           %{_prefix} and
%_prefix                /usr

So, we should probably hardcode "/sbin" instead of using sbindir.
What I'm confused about is how it could work so far. sbindir seems to have always been /usr/sbin.

Comment 3 Jirka Klimes 2011-09-26 08:24:49 UTC
Created attachment 524852 [details]
Proposed patch to fix the iscsiadm patch

Can we count on iscsiadm always being in /sbin?

Comment 4 Ales Kozumplik 2011-09-26 08:31:33 UTC
(In reply to comment #3)
> Created attachment 524852 [details]
> Proposed patch to fix the iscsiadm patch
> 
> Can we count on iscsiadm always being in /sbin?

I think so, it is needed very early in the system (dracut ramdisk) and those files are typically in /sbin.

Comment 5 Jirka Klimes 2011-09-26 14:00:12 UTC
Patch from comment #3 has been pushed upstream as f44959890b6eb9217470bc6809a0eb0f3f5efb9e

Comment 6 Fedora Update System 2011-09-27 14:11:58 UTC
NetworkManager-0.9.1.90-1.git20110927.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/NetworkManager-0.9.1.90-1.git20110927.fc15

Comment 7 Fedora Update System 2011-09-27 14:16:28 UTC
NetworkManager-0.9.1.90-2.git20110927.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/NetworkManager-0.9.1.90-2.git20110927.fc16

Comment 8 Fedora Update System 2011-09-27 17:33:37 UTC
Package NetworkManager-0.9.1.90-2.git20110927.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing NetworkManager-0.9.1.90-2.git20110927.fc16'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/NetworkManager-0.9.1.90-2.git20110927.fc16
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2011-09-27 19:24:09 UTC
NetworkManager-0.9.1.90-3.git20110927.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/NetworkManager-0.9.1.90-3.git20110927.fc16

Comment 10 Fedora Update System 2011-09-29 23:30:07 UTC
NetworkManager-0.9.1.90-1.git20110927.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2011-09-30 19:30:25 UTC
NetworkManager-0.9.1.90-3.git20110927.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.