Bug 742935

Summary:	Review Request: rubygem-metaclass - Adds a metaclass method to all Ruby objects
Product:	[Fedora] Fedora	Reporter:	Vít Ondruch <vondruch>
Component:	Package Review	Assignee:	Bohuslav "Slavek" Kabrda <bkabrda>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bkabrda, notting, package-review, tdawson
Target Milestone:	---	Flags:	bkabrda: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-10-04 13:06:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	742904, 743007

Description Vít Ondruch 2011-10-03 12:33:35 UTC

Spec URL: http://people.redhat.com/vondruch/rubygem-metaclass.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-metaclass-0.0.1-1.fcf17.src.rpm
Description: Adds a metaclass method to all Ruby objects

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3398963

Comment 1 Vít Ondruch 2011-10-03 12:36:50 UTC

Please note that it is not clear under what license this project was released, but I expect it is under the same terms as rubygem-mocha. Please see [1] for more information.

[1] https://github.com/floehopper/metaclass/issues/1

Comment 2 Vít Ondruch 2011-10-04 06:10:06 UTC

The license is MIT as clarified by upstream, so I'll update the spec file in a second.

Comment 3 Bohuslav "Slavek" Kabrda 2011-10-04 06:43:47 UTC

I'm taking this one.

Comment 4 Vít Ondruch 2011-10-04 06:52:43 UTC

Spec with updated license:

Spec URL: http://people.redhat.com/vondruch/rubygem-metaclass.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-metaclass-0.0.1-2.fcf17.src.rpm

Comment 5 Bohuslav "Slavek" Kabrda 2011-10-04 07:05:17 UTC

* I would consider including the license file from upstream (as a separate source) and including it as a %doc.
* %{geminstdir}/README.md should be marked as %doc.

Comment 6 Vít Ondruch 2011-10-04 07:52:02 UTC

(In reply to comment #5)
> * I would consider including the license file from upstream (as a separate
> source) and including it as a %doc.

I'll include the license file as soon as it makes into official release. It is not hard requirement, so it should not be blocker.

> * %{geminstdir}/README.md should be marked as %doc.

Moved into -doc subpackage and marked as %doc.


Spec URL: http://people.redhat.com/vondruch/rubygem-metaclass.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-metaclass-0.0.1-3.fcf17.src.rpm

Comment 7 Vít Ondruch 2011-10-04 07:55:37 UTC

(In reply to comment #6)
> (In reply to comment #5)
> > * I would consider including the license file from upstream (as a separate
> > source) and including it as a %doc.
> 
> I'll include the license file as soon as it makes into official release. It is
> not hard requirement, so it should not be blocker.

I added also the reference to the GitHub issue into the .spec file.

Comment 8 Bohuslav "Slavek" Kabrda 2011-10-04 09:40:04 UTC

APPROVED

Comment 9 Vít Ondruch 2011-10-04 10:24:58 UTC

Thank you for your review!




New Package SCM Request
=======================
Package Name: rubygem-metaclass
Short Description: Adds a metaclass method to all Ruby objects
Owners: vondruch
Branches: 
InitialCC:

Comment 10 Gwyn Ciesla 2011-10-04 12:21:26 UTC

Git done (by process-git-requests).

Comment 11 Troy Dawson 2014-07-28 18:52:43 UTC

Package Change Request
======================
Package Name: rubygem-metaclass
New Branches: epel7
Owners: tdawson

Comment 12 Gwyn Ciesla 2014-07-28 19:16:16 UTC

Git done (by process-git-requests).