Spec URL: http://people.redhat.com/vondruch/rubygem-metaclass.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-metaclass-0.0.1-1.fcf17.src.rpm Description: Adds a metaclass method to all Ruby objects Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3398963
Please note that it is not clear under what license this project was released, but I expect it is under the same terms as rubygem-mocha. Please see [1] for more information. [1] https://github.com/floehopper/metaclass/issues/1
The license is MIT as clarified by upstream, so I'll update the spec file in a second.
I'm taking this one.
Spec with updated license: Spec URL: http://people.redhat.com/vondruch/rubygem-metaclass.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-metaclass-0.0.1-2.fcf17.src.rpm
* I would consider including the license file from upstream (as a separate source) and including it as a %doc. * %{geminstdir}/README.md should be marked as %doc.
(In reply to comment #5) > * I would consider including the license file from upstream (as a separate > source) and including it as a %doc. I'll include the license file as soon as it makes into official release. It is not hard requirement, so it should not be blocker. > * %{geminstdir}/README.md should be marked as %doc. Moved into -doc subpackage and marked as %doc. Spec URL: http://people.redhat.com/vondruch/rubygem-metaclass.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-metaclass-0.0.1-3.fcf17.src.rpm
(In reply to comment #6) > (In reply to comment #5) > > * I would consider including the license file from upstream (as a separate > > source) and including it as a %doc. > > I'll include the license file as soon as it makes into official release. It is > not hard requirement, so it should not be blocker. I added also the reference to the GitHub issue into the .spec file.
APPROVED
Thank you for your review! New Package SCM Request ======================= Package Name: rubygem-metaclass Short Description: Adds a metaclass method to all Ruby objects Owners: vondruch Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ====================== Package Name: rubygem-metaclass New Branches: epel7 Owners: tdawson