Bug 744864
Summary: | Review Request: sugar-portfolio - Portfolio is a simple tool for generating slide show from starred Journal entries | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kalpa Welivitigoda <callkalpa> |
Component: | Package Review | Assignee: | Peter Robinson <pbrobinson> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | notting, package-review, pbrobinson |
Target Milestone: | --- | Flags: | pbrobinson:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | sugar-portfolio-15-2.fc15 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-12-02 17:21:48 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Kalpa Welivitigoda
2011-10-10 17:31:13 UTC
Here are the new file for v15 Spec URL: http://callkalpa.fedorapeople.org/sugar-portfolio/sugar-portfolio.spec SRPM URL: http://callkalpa.fedorapeople.org/sugar-portfolio/sugar-portfolio-15-1.fc15.src.rpm I'll review this Looks good. APPROVED! + rpmlint output $ rpmlint sugar-portfolio-15-1.fc16.src.rpm sugar-portfolio-15-1.fc16.noarch.rpm sugar-portfolio.spec sugar-portfolio.src: W: non-standard-group Sugar/Activities sugar-portfolio.noarch: W: non-standard-group Sugar/Activities sugar-portfolio.spec:6: W: non-standard-group Sugar/Activities 2 packages and 1 specfiles checked; 0 errors, 3 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + latest version packaged + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 689ebbee97a82125249f42837bcef362 Portfolio-15.tar.bz2 + package successfully builds on at least one architecture tested using koji scratch build + BuildRequires list all build dependencies + %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr n/a package owns all directories it creates n/a no duplicate files in %files + Package perserves timestamps on install + Permissions on files must be set properly + %defattr line + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package runtime n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream to include it n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji + the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a non -devel packages should require fully versioned base n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin n/a Package should have man files New Package SCM Request ======================= Package Name: sugar-portfolio Short Description: Portfolio is a simple tool for generating slide show from starred Journal entries Owners: callkalpa Branches: f15 f16 InitialCC: pbrobinson Git done (by process-git-requests). sugar-portfolio-15-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/sugar-portfolio-15-1.fc15 sugar-portfolio-15-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/sugar-portfolio-15-2.fc15 sugar-portfolio-15-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/sugar-portfolio-15-2.fc16 sugar-portfolio-15-2.fc16 has been pushed to the Fedora 16 stable repository. sugar-portfolio-15-2.fc15 has been pushed to the Fedora 15 stable repository. |