Bug 747080

Summary: Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Product: [Fedora] Fedora Reporter: Juan Camilo Prada Ojeda <juankprada>
Component: Package ReviewAssignee: Rex Dieter <rdieter>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: notting, package-review, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-15 20:14:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 201449    
Description Flags
Sudo patch for smb4k none

Description Juan Camilo Prada Ojeda 2011-10-18 18:17:00 UTC
Spec URL: http://public.juankprada.com/smb4k.spec
SRPM URL: http://public.juankprada.com/smb4k-0.10.10-1.fc16.src.rpm
Description: Smb4K is an SMB/CIFS share browser for KDE. It uses the Samba software suite to access the SMB/CIFS shares of the local network neighborhood. Its purpose is to provide a program that's easy to use and has as many features as possible.

Also, This is my first package and I would like someone to sponsor me to maintain this package.

Comment 1 Juan Camilo Prada Ojeda 2011-10-18 18:18:54 UTC
Created attachment 528860 [details]
Sudo patch for smb4k

Forgot to mention, this package includes a patch fo work around an issue with sudoers

Comment 2 Rex Dieter 2011-10-19 17:26:09 UTC
Fairly simple, and clean.

naming: ok

license: ok

macros: ok

scriptlets: ok

patches:  SHOULD: please document patches.  what are they for? what does it fix?  have you contacted upstream?  if so, provide bug or mailing list references.

sources: NOT OK
$ md5sum *.bz2
27851bf2e675006885e7706fb91ee8af  smb4k-0.10.10.tar.bz2

re-downloaded from upstream sources:
637ca913ffe9ac24a4dd09d4eddf0dcf  smb4k-0.10.10.tar.bz2

MUST: regenerate srpm with pristine upstream sources

Comment 3 Rex Dieter 2011-11-19 23:35:46 UTC
ping?  Juan, are you still interested in maintaining this in fedora?

Comment 4 Rex Dieter 2011-12-15 20:14:31 UTC
:( Looks like a dead review then.

Feel free to re-open when/if you're still interested in pursuing this.

Comment 5 Rex Dieter 2017-01-27 15:36:40 UTC
clearing review flag