Bug 749329
Summary: | Review Request: pcfi - PDF Core Font Information | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
Component: | Package Review | Assignee: | Severin Gehwolf <sgehwolf> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, sgehwolf |
Target Milestone: | --- | Flags: | sgehwolf:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-11-10 15:43:19 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 529441 |
Description
Orion Poplawski
2011-10-26 18:07:44 UTC
I'll take this one. Note that this is my first review of a font info package. I'm not sure which guidelines to follow. Anyhow here are my comments: 1. BuildRoot is not required anymore[1]. Please drop it. 2. URL should be: http://www.adobe.com/devnet/font/#pcfi 3. Perhaps there should be a note that this is repackaging of [2] only containing fonts info. Considering this I think it's OK to just use the jar on mavencentral. rpmlint output: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag [2] https://github.com/jukka/pcfi After the above fixes this package is good to go from my point of view. Thanks! Hmm, hadn't noticed the github stuff. How about this then: http://www.cora.nwra.com/~orion/fedora/pcfi.spec http://www.cora.nwra.com/~orion/fedora/pcfi-2010.08.09-2.20111103gitbd245c9.fc16.src.rpm * Thu Nov 3 2011 Orion Poplawski <orion.com> - 2010.08.09-2 - Use github upstream, build with maven - Drop BuildRoot Rpmlint output: pcfi.spec: W: invalid-url Source0: pcfi-2010.08.09.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. 0 packages and 1 specfiles checked; 0 errors, 1 warnings. This seems to be a better way to package this. As Source0 I suggest to use: https://github.com/jukka/pcfi/tarball/pcfi-2010.08.09 Other than that it's good to go. On second thought, the tag does not seem to have the README. Perhaps use: https://github.com/jukka/pcfi/tarball/master instead. REVIEW DONE Except that doesn't work. It's perfectly fine to have a comment explaining how the source file was generated from SCM. Anyway, I did update it a bit: %global commit bd245c9 # wget --content-disposition -N https://github.com/jukka/pcfi/tarball/master Source0: jukka-pcfi-pcfi-2010.08.09-2-g%{commit}.tar.gz Should help. New Package SCM Request ======================= Package Name: pcfi Short Description: PDF Core Font Information Owners: orion Branches: f15 f16 el6 InitialCC: Git done (by process-git-requests). Checked in and built. |