Spec URL: http://www.cora.nwra.com/~orion/fedora/pcfi.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/pcfi-2010.08.09-1.fc16.src.rpm Description: Collection of PDF core font information files downloaded from Adobe's Developer Center and elsewhere. This collection contains font metrics for the 14 PDF core fonts, CMaps for the PDF CJK fonts and the Adobe Glyph List. The files are stored inside the com/adobe/pdf/pcfi directory. See the individual files for exact licensing information.
I'll take this one.
Note that this is my first review of a font info package. I'm not sure which guidelines to follow. Anyhow here are my comments: 1. BuildRoot is not required anymore[1]. Please drop it. 2. URL should be: http://www.adobe.com/devnet/font/#pcfi 3. Perhaps there should be a note that this is repackaging of [2] only containing fonts info. Considering this I think it's OK to just use the jar on mavencentral. rpmlint output: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag [2] https://github.com/jukka/pcfi After the above fixes this package is good to go from my point of view. Thanks!
Hmm, hadn't noticed the github stuff. How about this then: http://www.cora.nwra.com/~orion/fedora/pcfi.spec http://www.cora.nwra.com/~orion/fedora/pcfi-2010.08.09-2.20111103gitbd245c9.fc16.src.rpm * Thu Nov 3 2011 Orion Poplawski <orion.com> - 2010.08.09-2 - Use github upstream, build with maven - Drop BuildRoot
Rpmlint output: pcfi.spec: W: invalid-url Source0: pcfi-2010.08.09.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. 0 packages and 1 specfiles checked; 0 errors, 1 warnings. This seems to be a better way to package this. As Source0 I suggest to use: https://github.com/jukka/pcfi/tarball/pcfi-2010.08.09 Other than that it's good to go.
On second thought, the tag does not seem to have the README. Perhaps use: https://github.com/jukka/pcfi/tarball/master instead.
REVIEW DONE
Except that doesn't work. It's perfectly fine to have a comment explaining how the source file was generated from SCM. Anyway, I did update it a bit: %global commit bd245c9 # wget --content-disposition -N https://github.com/jukka/pcfi/tarball/master Source0: jukka-pcfi-pcfi-2010.08.09-2-g%{commit}.tar.gz Should help.
New Package SCM Request ======================= Package Name: pcfi Short Description: PDF Core Font Information Owners: orion Branches: f15 f16 el6 InitialCC:
Git done (by process-git-requests).
Checked in and built.