| Summary: | Outdated version does not run under F16 with Gnome 3.2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stefan Schulze Frielinghaus <fedoraproject> | ||||
| Component: | gnome-shell-extension-presentation-mode | Assignee: | Fabian Affolter <mail> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 16 | CC: | alexjnewt, dev, gabor.papp, mail, rderooy, trevor | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-05-15 18:29:07 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Stefan Schulze Frielinghaus
2011-11-10 15:54:46 UTC
*** Bug 753502 has been marked as a duplicate of this bug. *** Can we please get a Git build of this extension? It is rather useful for when I need to do presentations when running on battery. It is the main thing that I'm missing since F15. I tried 0.2.gitc3ce6b2.fc16, 0.3.gitbe7e0ae.fc16 from updates-testing and the git version and none of them seems to work with gnome-shell-3.2.1-2.fc16. It works with the update from updates-testing !! After installing from updates-testing; gnome-tweak-tool-3.2.1-1.fc16.noarch gnome-shell-extension-presentation-mode-0-0.3.gitbe7e0ae.fc16.noarch I logged out and back in again, ran gnome-tweak-tool and was able to enable the extension after which it immediately showed up in the battery drop down. Thank you! Oh, then the problem in my case is that I don't have the battery drop down, because I'm trying to do this on a desktop computer. I managed to fix it based on this issue: https://github.com/RaphaelKimmig/Gnome-Presentation-Mode/issues/10 Thank you Robert for the battery drop down hint. Jep, version 0-0.3.gitbe7e0ae.fc16 works for me! Thanks for the update. The 3.2 compatibility has been fixed in the master git (as of October 17th 2011). Also I forked the master and I fixed the issue with the lack of battery drop down menu. If the battery menu does not exist, it places it in the a11y menu, and if the noa11y extension (the fedora packaged version) is turned on too, it places it in the user menu. I also made sure that this is compatible with alternative status menu. I made a pull request but the git owner seems to be busy, but I've tested it thoroughly and I can assure that there are no regressions. The source can be pulled here: git://github.com/Mystro256/Gnome-Presentation-Mode.git Can a packager build/upload this to bodhi for review? (In reply to comment #8) > I made a pull request but the git owner seems to be busy, but I've tested it > thoroughly and I can assure that there are no regressions. The source can be > pulled here: > git://github.com/Mystro256/Gnome-Presentation-Mode.git > > Can a packager build/upload this to bodhi for review? No, I can't include your source in the package. Upstream needs to fix it. If you provide a patch with your latest changes for be7e0ae of the original source, I can add that patch to the package. Okay, uploading patch, just give me a momment. Created attachment 545143 [details]
Patch to fix issues with users that do not have a battery menu (gnome-shell-presentation-mode-extension)
Intended for commit be7e0aea62 of git://github.com/RaphaelKimmig/Gnome-Presentation-Mode.git, which is currently head commit as of post date.
Adds automatic menu support for presentation mode, to allow users to use this extension if they do not have a battery menu. Resorts to a11y if no battery and further resorts to the user/status menu if the noa11y extension is enabled.
To apply patch:
-cd into extension.js folder
e.g.
"cd %_sourcedir/RaphaelKimmig-Gnome-Presentation-Mode-be7e0ae/presentationmode/"
-run patch
e.g.
"patch < %_sourcedir/nobatterymenu.patch"
Is this patch acceptable? (In reply to comment #12) > Is this patch acceptable? Works for me. (In reply to comment #13) > (In reply to comment #12) > > Is this patch acceptable? > > Works for me. Seconded. Now works for me, also. (In reply to comment #14) > > Seconded. Now works for me, also. Well, it worked until I restarted gnome-shell, then it didn't automatically load (even if enabled with gnome-tweak-tool). Re-running gnome-tweak-tool and disabling then re-enabling the extension brings it back. (In reply to comment #15) > (In reply to comment #14) > > > > Seconded. Now works for me, also. > > Well, it worked until I restarted gnome-shell, then it didn't automatically > load (even if enabled with gnome-tweak-tool). Re-running gnome-tweak-tool and > disabling then re-enabling the extension brings it back. Hmmm, odd... I can't confirm this what so ever, I'll see what I can do when I get back home later this month. this should be fixed upstream The updated extension is available at https://extensions.gnome.org/extension/94/presentation-mode/ |