Bug 752857 - Outdated version does not run under F16 with Gnome 3.2
Summary: Outdated version does not run under F16 with Gnome 3.2
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-shell-extension-presentation-mode
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabian Affolter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-10 15:54 UTC by Stefan Schulze Frielinghaus
Modified: 2012-05-15 18:29 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-15 18:29:07 UTC
Type: ---


Attachments (Terms of Use)
Patch to fix issues with users that do not have a battery menu (gnome-shell-presentation-mode-extension) (1.85 KB, patch)
2011-12-11 04:54 UTC, Jeremy Newton
no flags Details | Diff

Description Stefan Schulze Frielinghaus 2011-11-10 15:54:46 UTC
Description of problem:
This is an outdated version of the extension which does not run under Gnome 3.2


Version-Release number of selected component (if applicable):
0.2.gitc3ce6b2.fc16


Additional info:
Git version be7e0aea629d2180ba0b5c2398915cd43240dc87 works fine for me.

Comment 1 Fabian Affolter 2011-11-13 22:16:44 UTC
*** Bug 753502 has been marked as a duplicate of this bug. ***

Comment 2 Robert de Rooy 2011-11-20 17:56:58 UTC
Can we please get a Git build of this extension? It is rather useful for when I need to do presentations when running on battery. It is the main thing that I'm missing since F15.

Comment 3 Gabor Papp 2011-11-21 15:22:03 UTC
I tried 0.2.gitc3ce6b2.fc16, 0.3.gitbe7e0ae.fc16 from updates-testing and the git version and none of them seems to work with gnome-shell-3.2.1-2.fc16.

Comment 4 Robert de Rooy 2011-11-22 09:23:17 UTC
It works with the update from updates-testing !!

After installing from updates-testing;

gnome-tweak-tool-3.2.1-1.fc16.noarch
gnome-shell-extension-presentation-mode-0-0.3.gitbe7e0ae.fc16.noarch

I logged out and back in again, ran gnome-tweak-tool and was able to enable the extension after which it immediately showed up in the battery drop down.

Thank you!

Comment 5 Gabor Papp 2011-11-22 09:35:18 UTC
Oh, then the problem in my case is that I don't have the battery drop down, because I'm trying to do this on a desktop computer.

Comment 6 Gabor Papp 2011-11-22 09:48:44 UTC
I managed to fix it based on this issue:
https://github.com/RaphaelKimmig/Gnome-Presentation-Mode/issues/10

Thank you Robert for the battery drop down hint.

Comment 7 Stefan Schulze Frielinghaus 2011-11-22 17:10:28 UTC
Jep, version 0-0.3.gitbe7e0ae.fc16 works for me!

Thanks for the update.

Comment 8 Jeremy Newton 2011-12-05 02:13:26 UTC
The 3.2 compatibility has been fixed in the master git (as of October 17th 2011).
Also I forked the master and I fixed the issue with the lack of battery drop down menu. If the battery menu does not exist, it places it in the a11y menu, and if the noa11y extension (the fedora packaged version) is turned on too, it places it in the user menu. I also made sure that this is compatible with alternative status menu.

I made a pull request but the git owner seems to be busy, but I've tested it thoroughly and I can assure that there are no regressions. The source can be pulled here:
git://github.com/Mystro256/Gnome-Presentation-Mode.git

Can a packager build/upload this to bodhi for review?

Comment 9 Fabian Affolter 2011-12-08 23:34:40 UTC
(In reply to comment #8)
> I made a pull request but the git owner seems to be busy, but I've tested it
> thoroughly and I can assure that there are no regressions. The source can be
> pulled here:
> git://github.com/Mystro256/Gnome-Presentation-Mode.git
> 
> Can a packager build/upload this to bodhi for review?

No, I can't include your source in the package. Upstream needs to fix it. 

If you provide a patch with your latest changes for be7e0ae of the original source, I can add that patch to the package.

Comment 10 Jeremy Newton 2011-12-11 04:41:45 UTC
Okay, uploading patch, just give me a momment.

Comment 11 Jeremy Newton 2011-12-11 04:54:19 UTC
Created attachment 545143 [details]
Patch to fix issues with users that do not have a battery menu (gnome-shell-presentation-mode-extension)

Intended for commit be7e0aea62 of git://github.com/RaphaelKimmig/Gnome-Presentation-Mode.git, which is currently head commit as of post date.

Adds automatic menu support for presentation mode, to allow users to use this extension if they do not have a battery menu. Resorts to a11y if no battery and further resorts to the user/status menu if the noa11y extension is enabled.

To apply patch:

-cd into extension.js folder
e.g.
"cd %_sourcedir/RaphaelKimmig-Gnome-Presentation-Mode-be7e0ae/presentationmode/"

-run patch
e.g.
"patch < %_sourcedir/nobatterymenu.patch"

Comment 12 Jeremy Newton 2011-12-17 22:05:29 UTC
Is this patch acceptable?

Comment 13 Stefan Schulze Frielinghaus 2011-12-18 11:58:02 UTC
(In reply to comment #12)
> Is this patch acceptable?

Works for me.

Comment 14 James 2011-12-18 15:15:46 UTC
(In reply to comment #13)
> (In reply to comment #12)
> > Is this patch acceptable?
> 
> Works for me.

Seconded. Now works for me, also.

Comment 15 James 2011-12-22 14:22:09 UTC
(In reply to comment #14)
> 
> Seconded. Now works for me, also.

Well, it worked until I restarted gnome-shell, then it didn't automatically load (even if enabled with gnome-tweak-tool). Re-running gnome-tweak-tool and disabling then re-enabling the extension brings it back.

Comment 16 Jeremy Newton 2011-12-22 17:16:57 UTC
(In reply to comment #15)
> (In reply to comment #14)
> > 
> > Seconded. Now works for me, also.
> 
> Well, it worked until I restarted gnome-shell, then it didn't automatically
> load (even if enabled with gnome-tweak-tool). Re-running gnome-tweak-tool and
> disabling then re-enabling the extension brings it back.

Hmmm, odd... I can't confirm this what so ever, I'll see what I can do when I get back home later this month.

Comment 17 Jeremy Newton 2012-05-15 04:54:10 UTC
this should be fixed upstream

Comment 18 Fabian Affolter 2012-05-15 18:29:07 UTC
The updated extension is available at https://extensions.gnome.org/extension/94/presentation-mode/


Note You need to log in before you can comment on or make changes to this bug.