| Summary: | Review Request: gedit-code-assistance - gedit plugin for code assistance for C, C++ and Objective-C | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ignacio Casal Quinteiro (nacho) <icq> |
| Component: | Package Review | Assignee: | Elad Alfassa <elad> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | elad, notting, package-review, tbzatek |
| Target Milestone: | --- | Flags: | elad:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-11-29 10:04:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Ignacio Casal Quinteiro (nacho)
2011-11-13 16:04:37 UTC
Here is the rpmlint output: nacho@ansalon:~/checkout/fedora$ rpmlint gedit-code-assistance.spec ~/rpmbuild/RPMS/x86_64/gedit-code-assistance-0.1.1-1.fc16.x86_64.rpm ~/rpmbuild/RPMS/x86_64/gedit-code-assistance-debuginfo-0.1.1-1.fc16.x86_64.rpm ~/rpmbuild/SRPMS/gedit-code-assistance-0.1.1-1.fc16.src.rpm gedit-code-assistance.x86_64: W: summary-not-capitalized C gedit plugin for code assistance for C, C++ and Objective-C gedit-code-assistance.src: W: summary-not-capitalized C gedit plugin for code assistance for C, C++ and Objective-C 3 packages and 1 specfiles checked; 0 errors, 2 warnings. These warnings are fine as it is gedit and not Gedit. And here is the build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3511303 I will review this. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers Package looks good, although it makes gedit crash every time I open some C files, and it doesn't work as intended with other C files. I would like to debug this further before approving the package. There have been quite some important fixes upstream, not yet released but that we will release soon. Just released 0.1.2 and updated spec same link and the srpm in: http://people.gnome.org/~icq/gedit-code-assistance-0.1.2-1.fc16.src.rpm Seems fine to me, package is APPROVED. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers New Package SCM Request ======================= Package Name: gedit-code-assistance Short Description: gedit plugin for code assistance for C, C++ and Objective-C Owners: nacho Branches: f16 InitialCC: Git done (by process-git-requests). Built for f16. Closing the bug. Thanks to all of you. |