Bug 753764
| Summary: | shadow password expiration does not work in freeradius 2.1.10 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Tomi Leppikangas <tomi.leppikangas> | ||||
| Component: | freeradius | Assignee: | John Dennis <jdennis> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Patrik Kis <pkis> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 6.4 | CC: | dpal, ksrot, pkis, thoger | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | freeradius-2.1.12-1.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: |
Cause:
password expiration field for local passwords not checked by the unix module and debug information is erroneous.
Consequence:
A user with an expired password in the local password file will be authenticated despite having an expired password.
Fix:
Modify the source code to check the expiration and to accurately log the information in the radius log file.
Result:
A user with an expired local password is denied access and correct debugging information is written to the log file.
|
Story Points: | --- | ||||
| Clone Of: | |||||||
| : | 846474 (view as bug list) | Environment: | |||||
| Last Closed: | 2012-06-20 14:06:01 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 750334, 846474, 879045 | ||||||
| Attachments: |
|
||||||
This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. If you would like it considered as an exception in the current release, please ask your support representative. Created attachment 533539 [details]
patch to add password expire check to unix module
Patch to add password expire check to unix module and change log entry for account expire to "account has expired".
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
Cause:
password expiration field for local passwords not checked by the unix module and debug information is erroneous.
Consequence:
A user with an expired password in the local password file will be authenticated despite having an expired password.
Fix:
Modify the source code to check the expiration and to accurately log the information in the radius log file.
Result:
A user with an expired local password is denied access and correct debugging information is written to the log file.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2012-0881.html |
Description of problem: With freeradius configured with 'unix' module to use shadow passwords, password expire field is ignored. Also account expire field gives wrong debug info. Version-Release number of selected component (if applicable): freeradius-2.1.10-5.el6.x86_64 How reproducible: Add testuser with expired passwd: testuser:xxxxxxxxxxx:1551:0:180:7::: check that user still gets logged in to radius service Steps to Reproduce: 1. 2. 3. Actual results: user is logged in Expected results: user is not logged in, password expired written to log. Additional info: In cistron radius shadow check is like this: /* * Check if password has expired. */ if (spwd && spwd->sp_lstchg >= 0 && spwd->sp_max >= 0 && (time(NULL) / 86400) > (spwd->sp_lstchg + spwd->sp_max)) { log(L_AUTH, "unix_pass: [%s]: password has expired", name); return -1; } /* * Check if account has expired. */ if (spwd && spwd->sp_expire >= 0 && (time(NULL) / 86400) > spwd->sp_expire) { log(L_AUTH, "unix_pass: [%s]: account has expired", name); return -1; } In freeradus only expire field is tested, and wrong debug info printed: /* * Check if password has expired. */ if (spwd && spwd->sp_expire > 0 && (request->timestamp / 86400) > spwd->sp_expire) { radlog_request(L_AUTH, 0, request, "[%s]: password has expired", name); return RLM_MODULE_REJECT; } Should read "account is expired" because password expire status is not tested.