RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 753764 - shadow password expiration does not work in freeradius 2.1.10
Summary: shadow password expiration does not work in freeradius 2.1.10
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: freeradius
Version: 6.4
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: John Dennis
QA Contact: Patrik Kis
URL:
Whiteboard:
Depends On:
Blocks: 750334 846474 CVE-2011-4966
TreeView+ depends on / blocked
 
Reported: 2011-11-14 12:39 UTC by Tomi Leppikangas
Modified: 2012-11-21 22:36 UTC (History)
4 users (show)

Fixed In Version: freeradius-2.1.12-1.el6
Doc Type: Bug Fix
Doc Text:
Cause: password expiration field for local passwords not checked by the unix module and debug information is erroneous. Consequence: A user with an expired password in the local password file will be authenticated despite having an expired password. Fix: Modify the source code to check the expiration and to accurately log the information in the radius log file. Result: A user with an expired local password is denied access and correct debugging information is written to the log file.
Clone Of:
: 846474 (view as bug list)
Environment:
Last Closed: 2012-06-20 14:06:01 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
patch to add password expire check to unix module (858 bytes, patch)
2011-11-14 14:25 UTC, Tomi Leppikangas 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:0881 0 normal SHIPPED_LIVE freeradius bug fix and enhancement update 2012-06-19 20:47:36 UTC

Description Tomi Leppikangas 2011-11-14 12:39:00 UTC 
Description of problem:

With freeradius configured with 'unix' module to use shadow passwords, password expire field is ignored. Also account expire field gives wrong debug info.


Version-Release number of selected component (if applicable):
freeradius-2.1.10-5.el6.x86_64


How reproducible:
Add testuser with expired passwd:
testuser:xxxxxxxxxxx:1551:0:180:7:::

check that user still gets logged in to radius service

Steps to Reproduce:
1.
2.
3.
  
Actual results:
user is logged in

Expected results:
user is not logged in, password expired written to log.

Additional info:

In cistron radius shadow check is like this:


        /*
         *      Check if password has expired.
         */
        if (spwd && spwd->sp_lstchg >= 0 && spwd->sp_max >= 0 &&
            (time(NULL) / 86400) > (spwd->sp_lstchg + spwd->sp_max)) {
                log(L_AUTH, "unix_pass: [%s]: password has expired", name);
                return -1;
        }

        /*
         *      Check if account has expired.
         */
        if (spwd && spwd->sp_expire >= 0 &&
            (time(NULL) / 86400) > spwd->sp_expire) {
                log(L_AUTH, "unix_pass: [%s]: account has expired", name);
                return -1;
        }


In freeradus only expire field is tested, and wrong debug info printed:
        /*
         *      Check if password has expired.
         */
        if (spwd && spwd->sp_expire > 0 &&
            (request->timestamp / 86400) > spwd->sp_expire) {
                radlog_request(L_AUTH, 0, request, "[%s]: password has expired", name);
                return RLM_MODULE_REJECT;
        }


Should read "account is expired" because password expire status is not tested.
Comment 2 RHEL Program Management 2011-11-14 13:09:08 UTC 
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.
Comment 3 Tomi Leppikangas 2011-11-14 14:25:38 UTC 
Created attachment 533539 [details]
patch to add password expire check to unix module

Patch to add password expire check to unix module and change log entry for account expire to "account has expired".
Comment 7 John Dennis 2012-04-24 16:53:55 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause:

password expiration field for local passwords not checked by the unix module and debug information is erroneous.

Consequence:

A user with an expired password in the local password file will be authenticated despite having an expired password.

Fix:

Modify the source code to check the expiration and to accurately log the information in the radius log file.

Result:

A user with an expired local password is denied access and correct debugging information is written to the log file.
Comment 10 errata-xmlrpc 2012-06-20 14:06:01 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0881.html
Comment 12 Tomas Hoger 2012-11-21 09:56:35 UTC 
Upstream commit:

https://github.com/alandekok/freeradius-server/commit/1b1ec5ce75e224bd1755650c18ccdaa6dc53e605
Note You need to log in before you can comment on or make changes to this bug.