| Summary: | Review Request: openstack-quantum - Virtual network service for OpenStack | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bob Kukura <rkukura> |
| Component: | Package Review | Assignee: | Bob Kukura <rkukura> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 16 | CC: | lpeer, markmc, notting, package-review, p |
| Target Milestone: | --- | Flags: | markmc:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | openstack-quantum-2011.3-1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-11-30 01:56:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Bob Kukura
2011-11-18 16:01:10 UTC
I'll take this rpmlint output ... $> rpmlint openstack-quantum.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $> rpmlint openstack-quantum-2011.3-1.fc15.noarch.rpm python-quantum-2011.3-1.fc15.noarch.rpm openstack-quantum.noarch: W: non-standard-uid /var/lib/quantum quantum openstack-quantum.noarch: W: non-standard-gid /var/lib/quantum quantum openstack-quantum.noarch: W: non-standard-uid /var/log/quantum quantum openstack-quantum.noarch: W: non-standard-gid /var/log/quantum quantum openstack-quantum.noarch: W: non-standard-uid quantum-cli openstack-quantum.noarch: W: no-manual-page-for-binary quantum-server 2 packages and 0 specfiles checked; 0 errors, 6 warnings. $> $ rpmlint openstack-quantum-2011.3-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. For the no-manual-page-for-binary warning, you need to file a bug against the package once it has been imported. See bug #734349 for example The non-standard-uid warning is just because the uidgid file in setup hasn't been updated for #752842 Most boring package review EVER!
Conforms to all MUSTs/SHOULDs in the review guidelines, conforms to the packaging guidelines
There's one significant issue - openstack-quantum should Requires: python-cheetah because otherwise glance-cli fails with:
Traceback (most recent call last):
File "/usr/bin/quantum-cli", line 22, in <module>
import Cheetah.Template as cheetah_template
ImportError: No module named Cheetah.Template
And I've one little nitpick - please run:
$> sed -i 's/[ \t]*$//' openstack-quantum.spec
But, you'll trivially fix those before importing, so I'm marking this as approved
New Package SCM Request ======================= Package Name: openstack-quantum Short Description: Virtual network service for OpenStack Owners: rkukura Branches: f16 InitialCC: markmc Spec file and SRPM at URLs above have been updated. Git done (by process-git-requests). openstack-quantum-2011.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/openstack-quantum-2011.3-1.fc16 openstack-quantum-2011.3-1.fc16 has been pushed to the Fedora 16 testing repository. openstack-quantum-2011.3-1.fc16 has been pushed to the Fedora 16 stable repository. Package Change Request ====================== Package Name: openstack-quantum New Branches: el6 Owners: rkukura apevec chrisw gkotton markmc pbrady rackerjoe This is to support the Essex upgrade in EPEL Git done (by process-git-requests). Removed rackerjoe, not a sponsored packager. Add later in pkgdb once this changes. |