Bug 755033 - Review Request: openstack-quantum - Virtual network service for OpenStack
Summary: Review Request: openstack-quantum - Virtual network service for OpenStack
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 16
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Bob Kukura
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-18 16:01 UTC by Bob Kukura
Modified: 2014-02-27 23:17 UTC (History)
5 users (show)

Fixed In Version: openstack-quantum-2011.3-1.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-30 01:56:11 UTC
Type: ---
markmc: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Bob Kukura 2011-11-18 16:01:10 UTC
Spec URL: <http://rkukura.fedorapeople.org/review/openstack-quantum.spec>
SRPM URL: <http://rkukura.fedorapeople.org/review/openstack-quantum-2011.3-1.fc16.src.rpm>
Description: 

Quantum is a virtual network service for Openstack, and a part of
Netstack. Just like OpenStack Nova provides an API to dynamically
request and configure virtual servers, Quantum provides an API to
dynamically request and configure virtual networks. These networks
connect "interfaces" from other OpenStack services (e.g., virtual NICs
from Nova VMs). The Quantum API supports extensions to provide
advanced network capabilities (e.g., QoS, ACLs, network monitoring,
etc.)

Comment 1 Mark McLoughlin 2011-11-18 17:37:14 UTC
I'll take this

Comment 2 Mark McLoughlin 2011-11-18 17:41:32 UTC
rpmlint output ...

$> rpmlint openstack-quantum.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$> rpmlint openstack-quantum-2011.3-1.fc15.noarch.rpm python-quantum-2011.3-1.fc15.noarch.rpm
openstack-quantum.noarch: W: non-standard-uid /var/lib/quantum quantum
openstack-quantum.noarch: W: non-standard-gid /var/lib/quantum quantum
openstack-quantum.noarch: W: non-standard-uid /var/log/quantum quantum
openstack-quantum.noarch: W: non-standard-gid /var/log/quantum quantum
openstack-quantum.noarch: W: non-standard-uid quantum-cli
openstack-quantum.noarch: W: no-manual-page-for-binary quantum-server
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

$> $ rpmlint openstack-quantum-2011.3-1.fc15.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


For the no-manual-page-for-binary warning, you need to file a bug against the package once it has been imported. See bug #734349 for example

The non-standard-uid warning is just because the uidgid file in setup hasn't been updated for #752842

Comment 3 Mark McLoughlin 2011-11-18 17:55:25 UTC
Most boring package review EVER!

Conforms to all MUSTs/SHOULDs in the review guidelines, conforms to the packaging guidelines

There's one significant issue - openstack-quantum should Requires: python-cheetah because otherwise glance-cli fails with:

  Traceback (most recent call last):
    File "/usr/bin/quantum-cli", line 22, in <module>
      import Cheetah.Template as cheetah_template
  ImportError: No module named Cheetah.Template

And I've one little nitpick - please run:

  $> sed -i 's/[ \t]*$//' openstack-quantum.spec

But, you'll trivially fix those before importing, so I'm marking this as approved

Comment 4 Bob Kukura 2011-11-18 19:44:05 UTC
New Package SCM Request
=======================
Package Name: openstack-quantum
Short Description: Virtual network service for OpenStack
Owners: rkukura
Branches: f16
InitialCC: markmc

Comment 5 Bob Kukura 2011-11-18 20:00:15 UTC
Spec file and SRPM at URLs above have been updated.

Comment 6 Gwyn Ciesla 2011-11-18 20:34:18 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2011-11-18 22:26:57 UTC
openstack-quantum-2011.3-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/openstack-quantum-2011.3-1.fc16

Comment 8 Fedora Update System 2011-11-19 23:33:45 UTC
openstack-quantum-2011.3-1.fc16 has been pushed to the Fedora 16 testing repository.

Comment 9 Fedora Update System 2011-11-30 01:56:11 UTC
openstack-quantum-2011.3-1.fc16 has been pushed to the Fedora 16 stable repository.

Comment 10 Pádraig Brady 2012-04-05 09:17:52 UTC
Package Change Request
======================
Package Name: openstack-quantum
New Branches: el6
Owners: rkukura apevec chrisw gkotton markmc pbrady rackerjoe

This is to support the Essex upgrade in EPEL

Comment 11 Gwyn Ciesla 2012-04-05 12:15:42 UTC
Git done (by process-git-requests).

Removed rackerjoe, not a sponsored packager.  Add later in pkgdb once this
changes.


Note You need to log in before you can comment on or make changes to this bug.