Bug 755498

Summary:	Review Request: trayer - Lightweight GTK2-based systray for UNIX desktop
Product:	[Fedora] Fedora	Reporter:	Minh Ngo <nlminhtl>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mario.blaettermann, notting, package-review, petersen, robinlee.sysu, volker27
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-07-07 19:26:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Minh Ngo 2011-11-21 10:21:46 UTC

Spec URL: https://raw.github.com/Ignotus/trayer-fedora/53c21d91c901fe3153393d92c4dd041c93d7e0b4/trayer.spec
SRPM URL: https://github.com/Ignotus/trayer-fedora/blob/53c21d91c901fe3153393d92c4dd041c93d7e0b4/trayer-1.1.3-1.fc16.src.rpm?raw=true
Description: trayer is a small program designed to provide systray functionality present in GNOME/KDE
desktop environments for window managers which do not support that function. System tray
is a place, where various applications put their icons, so they are always visible presenting
status of applications and allowing user to control programs.

The code started out as an extraction from fbpanel.

Comment 1 Volker Fröhlich 2011-12-09 18:39:15 UTC

According to the files, the license is GPLv2+, not MIT. The FSF address is wrong. Feel free to correct it or not, but inform upstream. Inform upstream, they're shipping a wrong license file and therefore don't include it or replace it with the proper one for Fedora. Even other files state LGPL.

I'm not really sure, whether you're packaging a real release or a snapshot. If it is a snapshot, you must change release and give guidelines how to build the tarball you're using. If it is not a snapshot, use a URL for Source0.

See http://fedoraproject.org/wiki/Packaging:NamingGuidelines

The build does not respect Fedora's optflags.

You can drop defattr.

CREDITS is not UTF8.

Buildroot, clean section and the rm in the install section are only useful for EPEL 5 or older. If you're not going for these, remove them.

Don't exceed 80 characters per line with your description.

Please align the entries for Source0 and Group with the rest (mixed use of tabs and spaces)

Ask upstream to release tarball names and directories that don't contain a Git hash, but name-version or something different that makes sense: http://ftp.sunet.se/pub/Linux/kernel.org/software/scm/git/docs/git-archive.html

Comment 2 Volker Fröhlich 2012-04-10 21:50:27 UTC

Any news, Minh?

Comment 3 Robin Lee 2012-06-15 07:42:42 UTC

Any news? There is a new duplicated request. If the requester is not responsive, then this one will be marked as duplicate.

Comment 4 Mario Blättermann 2012-07-07 19:26:25 UTC

Because the reporter doesn't response within a reasonable time frame, this review request will be closed now.

*** This bug has been marked as a duplicate of bug 827101 ***