Bug 755498 - Review Request: trayer - Lightweight GTK2-based systray for UNIX desktop
Summary: Review Request: trayer - Lightweight GTK2-based systray for UNIX desktop
Keywords:
Status: CLOSED DUPLICATE of bug 827101
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-21 10:21 UTC by Minh Ngo
Modified: 2012-07-07 19:26 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-07 19:26:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Minh Ngo 2011-11-21 10:21:46 UTC
Spec URL: https://raw.github.com/Ignotus/trayer-fedora/53c21d91c901fe3153393d92c4dd041c93d7e0b4/trayer.spec
SRPM URL: https://github.com/Ignotus/trayer-fedora/blob/53c21d91c901fe3153393d92c4dd041c93d7e0b4/trayer-1.1.3-1.fc16.src.rpm?raw=true
Description: trayer is a small program designed to provide systray functionality present in GNOME/KDE
desktop environments for window managers which do not support that function. System tray
is a place, where various applications put their icons, so they are always visible presenting
status of applications and allowing user to control programs.

The code started out as an extraction from fbpanel.

Comment 1 Volker Fröhlich 2011-12-09 18:39:15 UTC
According to the files, the license is GPLv2+, not MIT. The FSF address is wrong. Feel free to correct it or not, but inform upstream. Inform upstream, they're shipping a wrong license file and therefore don't include it or replace it with the proper one for Fedora. Even other files state LGPL.

I'm not really sure, whether you're packaging a real release or a snapshot. If it is a snapshot, you must change release and give guidelines how to build the tarball you're using. If it is not a snapshot, use a URL for Source0.

See http://fedoraproject.org/wiki/Packaging:NamingGuidelines

The build does not respect Fedora's optflags.

You can drop defattr.

CREDITS is not UTF8.

Buildroot, clean section and the rm in the install section are only useful for EPEL 5 or older. If you're not going for these, remove them.

Don't exceed 80 characters per line with your description.

Please align the entries for Source0 and Group with the rest (mixed use of tabs and spaces)

Ask upstream to release tarball names and directories that don't contain a Git hash, but name-version or something different that makes sense: http://ftp.sunet.se/pub/Linux/kernel.org/software/scm/git/docs/git-archive.html

Comment 2 Volker Fröhlich 2012-04-10 21:50:27 UTC
Any news, Minh?

Comment 3 Robin Lee 2012-06-15 07:42:42 UTC
Any news? There is a new duplicated request. If the requester is not responsive, then this one will be marked as duplicate.

Comment 4 Mario Blättermann 2012-07-07 19:26:25 UTC
Because the reporter doesn't response within a reasonable time frame, this review request will be closed now.

*** This bug has been marked as a duplicate of bug 827101 ***


Note You need to log in before you can comment on or make changes to this bug.