| Summary: | Review Request: telepathy-farstream - Telepathy client library to handle Call channels | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brian Pepple <bdpepple> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review |
| Target Milestone: | --- | Flags: | notting:
fedora-review+
petersen: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | telepathy-farstream-0.2.2-2.fc17 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-16 21:12:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 797694 | ||
| Bug Blocks: | |||
|
Description
Brian Pepple
2011-11-21 21:28:55 UTC
This package would appear to need some s/farsight/farstream work done, and updated to 0.2.1? (In reply to comment #1) > This package would appear to need some s/farsight/farstream work done, and > updated to 0.2.1? Right. I'm still sorting out the deps that it needs. Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream-0.2.1-1.fc16.src.rpm i386 build results: http://bpepple.fedorapeople.org/rpms/tp-farstream/ Description: telepathy-farstream is a Telepathy client library that uses Farsight2 to handle Call channels - Package meets naming and packaging guidelines - ***
Description and URL need /farsight/farsteam/ substitutions.
- Spec file matches base package name. - OK
- Spec has consistent macro usage. - OK
- Meets Packaging Guidelines. - OK
- License - LGPLv2+ (OK)
- License field in spec matches - OK
- License file included in package - OK
- Spec in American English - OK
- Spec is legible. - OK
- Sources match upstream md5sum: - OK
409036c07dcd7d8729ff9c84366c8967 telepathy-farstream-0.2.1.tar.gz
- Package needs ExcludeArch - N/A
- BuildRequires correct - OK
- Spec handles locales/find_lang - N/A
- Package is code or permissible content. - OK
- Doc subpackage needed/used. - N/A
- Packages %doc files don't affect runtime. - OK
- Headers/static libs in -devel subpackage. - OK
- Spec has needed ldconfig in post and postun - OK
- .pc files in -devel subpackage/requires pkgconfig - OK
- .so files in -devel subpackage. - OK
- -devel package Requires: %{name} = %{version}-%{release} -OK
- .la files are removed. - OK
- Package is a GUI app and has a .desktop file - N/A
- Package compiles and builds on at least one arch. - tested x86_64 w/mock
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own. -OK
- Package owns all the directories it creates. - OK
- No rpmlint output. - ***
telepathy-farstream.src:37: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 37)
- final provides and requires are sane: ***
telepathy-farsight & telepathy-farsight-devel provides should likely use %{version}, not be hardcoded.
SHOULD Items:
- Should build in mock. - tested x86_64
- Should build on all supported archs - didn't test
- Should function as described. - didn't test
- Should have sane scriptlets. - OK
- Should have subpackages require base package with fully versioned depend. - OK
- Should have dist tag - OK
- Should package latest version - OK
Issues:
1. Description and URL need /farsight/farsteam/ substitutions.
2. Spaces & tabs in the spec
3. telepathy-farsight & telepathy-farsight-devel provides should likely use %{version}, not be hardcoded.
Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream-0.2.1-2.fc16.src.rpm Diff: http://bpepple.fedorapeople.org/rpms/spec.diff * Mon Mar 5 2012 Brian Pepple <bpepple> - 0.2.1-2 - Use macro for version in provides. - Change reference Farsight in description to Farstream. Didn't change reference to url, since as of Saturday a page for tp-farstream didn't exist. freedesktop.org appears to be down right, so I can't check to see if this has changed since then. Looks good. APPROVED. New Package SCM Request ======================= Package Name: telepathy-farstream Short Description: Telepathy client library to handle Call channels Owners: bpepple Branches: f17 InitialCC: Git done (by process-git-requests). empathy-3.3.91-1.fc17,telepathy-farstream-0.2.1-2.fc17,farstream-0.1.1-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/empathy-3.3.91-1.fc17,telepathy-farstream-0.2.1-2.fc17,farstream-0.1.1-4.fc17 pidgin-2.10.1-4.fc17,papyon-0.5.6-3.fc17,farstream-0.1.1-4.fc17,telepathy-farstream-0.2.2-1.fc17,empathy-3.3.91-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/pidgin-2.10.1-4.fc17,papyon-0.5.6-3.fc17,farstream-0.1.1-4.fc17,telepathy-farstream-0.2.2-1.fc17,empathy-3.3.91-2.fc17 telepathy-farstream-0.2.2-2.fc17, farstream-0.1.1-5.fc17, amsn-0.98.4-10.fc17, pidgin-2.10.1-4.fc17, papyon-0.5.6-3.fc17, empathy-3.3.91-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |