Bug 755729

Summary:	Error message for resize2fs-M needs tweaking
Product:	[Community] Virtualization Tools	Reporter:	Alex Beamish <talexb>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	gaowanlong, mbooth, virt-maint
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-05-03 13:47:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Alex Beamish 2011-11-21 21:38:50 UTC

Description of problem:

Running the command 'resize2fs-M /dev/vda1'

at the guestfish prompt produces the error message

  libguestfs: error: resize2fs_M: resize2fs 1.41.14 (22-Dec-2010)
  Please run 'e2fsck -f /dev/vda1' first.

The actual command that should be run is one without the space between 'e2fsck' and '-f', in other words, 'e2fsck-f'.


Version-Release number of selected component (if applicable):

guestfish 1.14.0


How reproducible:

I saw it once -- since this an error message, I imagine it's reproducible.

Steps to Reproduce:
1. Add a VDI to guestfish, run it.
2. resize2fs-M /dev/vda1
3. Observe error reproduced above.


Actual results:

As above.


Expected results:

  libguestfs: error: resize2fs_M: resize2fs 1.41.14 (22-Dec-2010)
  Please run 'e2fsck-f /dev/vda1' first.


Additional info:

Comment 1 Richard W.M. Jones 2011-11-21 22:08:30 UTC

We'd need to capture the error message (which comes from the
resize2fs utility itself) and rewrite it in the daemon.

Comment 2 Wanlong Gao 2012-01-14 01:40:05 UTC

sent the fix patch to upstream:
https://www.redhat.com/archives/libguestfs/2012-January/msg00102.html

Comment 3 Richard W.M. Jones 2012-01-14 08:18:34 UTC

Thanks, this is upstream now:

https://github.com/libguestfs/libguestfs/commit/0eaf06e673833bc25673d5c3d2487fffae310285

Comment 4 Richard W.M. Jones 2012-03-09 18:15:46 UTC

Reopening, see:

https://www.redhat.com/archives/libguestfs/2012-March/msg00049.html

Comment 5 Richard W.M. Jones 2012-05-03 13:47:37 UTC

OK, the upstream policy is not to rewrite error messages,
because whenever we try to do it, it's bitten us.

If necessary we'll document them, which is what I have
done here:
https://www.redhat.com/archives/libguestfs/2012-March/msg00054.html