Bug 757368
| Summary: | Review Request: telepathy-kde-integration-module - KDE integration for telepathy | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | nucleo <alekcejk> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alekcejk, kevin, notting, package-review |
| Target Milestone: | --- | Flags: | alekcejk:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-08 16:29:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Rex Dieter
2011-11-26 17:47:29 UTC
desktop files installed only in %{_kde4_datadir}/kde4/services/ so no need to add "BuildRequires: desktop-file-utils"
"BuildRequires: gettext" needed. Name: ok Summary: ok (but remove space at end of line) Source0: ok md5sum telepathy-kde-integration-module-0.2.0.tar.bz2 c9bdb73c049499c0f72c4ee5fa4fb8fe telepathy-kde-integration-module-0.2.0.tar.bz2 Build in mock failed if "BuildRequires: gettext" missing. License: should be LGPLv2+ (GPLv2+ now) So please fix BuildRequires and License, then package can be approved. Spec : http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-integration-module.spec SRPM: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-integration-module-0.2.0-1.fc16.src.rpm %changelog * Wed Dec 21 2011 Rex Dieter <rdieter> 0.2.0-2 - BR: -desktop-file-utils, +gettext - License: LGPLv2+ I didn't noticed before that %find_lang should be moved to %install oops, right Spec : http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-integration-module.spec SRPM: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-integration-module-0.2.0-3.fc16.src.rpm %changelog * Wed Dec 21 2011 Rex Dieter <rdieter> 0.2.0-3 - move %%find_lang to %%install rpmlint output: $ rpmlint telepathy-kde-integration-module-0.2.0-3.fc16.i686.rpm telepathy-kde-integration-module-debuginfo-0.2.0-3.fc16.i686.rpm telepathy-kde-integration-module-0.2.0-3.fc16.src.rpm telepathy-kde-integration-module-debuginfo.i686: E: description-line-too-long C This package provides debug information for package telepathy-kde-integration-module. 3 packages and 0 specfiles checked; 1 errors, 0 warnings. We can't do anything with description for debuginfo so package APPROVED. Looks like they going to rename everything http://mail.kde.org/pipermail/kde-telepathy/2011-December/004681.html *** This bug has been marked as a duplicate of bug 784954 *** |