Bug 759593
| Summary: | rocs 4.7.80-1 not built with $RPM_OPT_FLAGS | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> |
| Component: | rocs | Assignee: | Kevin Kofler <kevin> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jreznik, kevin, ltinkl, rdieter, rnovacek, than |
| Target Milestone: | --- | Keywords: | Regression |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rocs-4.7.80-2.fc17 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-03 00:35:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 496968 | ||
|
Description
Ville Skyttä
2011-12-02 19:21:28 UTC
I'm investigating. I suspect upstream must have made some broken change to its CMakeLists.txt files. This commit is incorrect: https://projects.kde.org/projects/kde/kdeedu/rocs/repository/revisions/43b6ccf22174629ebec0a0579365c4269cf0fb58/diff/CMakeLists.txt This overwrites CMAKE_CXX_FLAGS instead of adding to it. That line should be:
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${KDE4_ENABLE_EXCEPTIONS}" )
I'm going to patch this in Rawhide ASAP and then push that trivial fix upstream.
Should be fixed in rocs-4.7.80-2.fc17. Grrr, this fails to build with the proper flags: CMakeFiles/rocs_assignvaluesplugin.dir/assignvalueswidget.o: In function `AssignValuesWidget::assignValues()': /builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:104: undefined reference to `ValueModifier::ValueModifier()' /builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:113: undefined reference to `ValueModifier::enumerate(QList<boost::shared_ptr<Data> >, int, bool)' /builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:116: undefined reference to `ValueModifier::enumerate(QList<boost::shared_ptr<Pointer> >, int, bool)' /builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:139: undefined reference to `ValueModifier::assignRandomReals(QList<boost::shared_ptr<Data> >, double, double, int, bool)' /builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:104: undefined reference to `ValueModifier::~ValueModifier()' /builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:126: undefined reference to `ValueModifier::assignRandomIntegers(QList<boost::shared_ptr<Data> >, int, int, int, bool)' /builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:129: undefined reference to `ValueModifier::assignRandomIntegers(QList<boost::shared_ptr<Pointer> >, int, int, int, bool)' /builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:142: undefined reference to `ValueModifier::assignRandomReals(QList<boost::shared_ptr<Pointer> >, double, double, int, bool)' /builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:104: undefined reference to `ValueModifier::~ValueModifier()' I think the problem here is that some export macro is missing, which upstream didn't notice because they were trashing the visibility flags. Grrr! Should be fixed now (and the fix also happens to fix compilation on Window$ even without my previous patch, because hidden visibility is the default there, so that gives me an excuse to commit the patch upstream as soon as I verified that it builds even though upstream is in Beta 2 tagging freeze :-p ). Fixed in rocs-4.7.80-2.fc17: http://koji.fedoraproject.org/koji/getfile?taskID=3559418&name=build.log Fixes pushed upstream, too. |