Bug 759593 - rocs 4.7.80-1 not built with $RPM_OPT_FLAGS
Summary: rocs 4.7.80-1 not built with $RPM_OPT_FLAGS
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rocs
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Kofler
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DebugInfo
TreeView+ depends on / blocked
 
Reported: 2011-12-02 19:21 UTC by Ville Skyttä
Modified: 2011-12-03 00:35 UTC (History)
6 users (show)

Fixed In Version: rocs-4.7.80-2.fc17
Clone Of:
Environment:
Last Closed: 2011-12-03 00:35:52 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ville Skyttä 2011-12-02 19:21:28 UTC
rocs 4.7.80-1 is not built with $RPM_OPT_FLAGS:

http://kojipkgs.fedoraproject.org/packages/rocs/4.7.80/1.fc17/data/logs/x86_64/build.log

4.7.4-1 does not have this problem:

http://kojipkgs.fedoraproject.org/packages/rocs/4.7.4/1.fc16/data/logs/x86_64/build.log

Comment 1 Kevin Kofler 2011-12-02 22:53:03 UTC
I'm investigating. I suspect upstream must have made some broken change to its CMakeLists.txt files.

Comment 2 Kevin Kofler 2011-12-02 22:55:23 UTC
This commit is incorrect:
https://projects.kde.org/projects/kde/kdeedu/rocs/repository/revisions/43b6ccf22174629ebec0a0579365c4269cf0fb58/diff/CMakeLists.txt

This overwrites CMAKE_CXX_FLAGS instead of adding to it.

Comment 3 Kevin Kofler 2011-12-02 23:00:37 UTC
That line should be:
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${KDE4_ENABLE_EXCEPTIONS}" )

I'm going to patch this in Rawhide ASAP and then push that trivial fix upstream.

Comment 4 Kevin Kofler 2011-12-02 23:15:15 UTC
Should be fixed in rocs-4.7.80-2.fc17.

Comment 5 Kevin Kofler 2011-12-02 23:20:40 UTC
Grrr, this fails to build with the proper flags:

CMakeFiles/rocs_assignvaluesplugin.dir/assignvalueswidget.o: In function `AssignValuesWidget::assignValues()':
/builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:104: undefined reference to `ValueModifier::ValueModifier()'
/builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:113: undefined reference to `ValueModifier::enumerate(QList<boost::shared_ptr<Data> >, int, bool)'
/builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:116: undefined reference to `ValueModifier::enumerate(QList<boost::shared_ptr<Pointer> >, int, bool)'
/builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:139: undefined reference to `ValueModifier::assignRandomReals(QList<boost::shared_ptr<Data> >, double, double, int, bool)'
/builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:104: undefined reference to `ValueModifier::~ValueModifier()'
/builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:126: undefined reference to `ValueModifier::assignRandomIntegers(QList<boost::shared_ptr<Data> >, int, int, int, bool)'
/builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:129: undefined reference to `ValueModifier::assignRandomIntegers(QList<boost::shared_ptr<Pointer> >, int, int, int, bool)'
/builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:142: undefined reference to `ValueModifier::assignRandomReals(QList<boost::shared_ptr<Pointer> >, double, double, int, bool)'
/builddir/build/BUILD/rocs-4.7.80/src/Plugins/AssignValues/assignvalueswidget.cpp:104: undefined reference to `ValueModifier::~ValueModifier()'

Comment 6 Kevin Kofler 2011-12-02 23:22:23 UTC
I think the problem here is that some export macro is missing, which upstream didn't notice because they were trashing the visibility flags. Grrr!

Comment 7 Kevin Kofler 2011-12-02 23:34:35 UTC
Should be fixed now (and the fix also happens to fix compilation on Window$ even without my previous patch, because hidden visibility is the default there, so that gives me an excuse to commit the patch upstream as soon as I verified that it builds even though upstream is in Beta 2 tagging freeze :-p ).

Comment 8 Kevin Kofler 2011-12-03 00:35:52 UTC
Fixed in rocs-4.7.80-2.fc17:
http://koji.fedoraproject.org/koji/getfile?taskID=3559418&name=build.log

Fixes pushed upstream, too.


Note You need to log in before you can comment on or make changes to this bug.