| Summary: | The SuperFastHash function used in dictionaries is broken. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Sebastian Smyczyński <smyczek> | ||||
| Component: | core | Assignee: | Anand Avati <aavati> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | mainline | CC: | amarts, chrisw, gluster-bugs | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
(In reply to comment #1) > Created an attachment (id=37) [details] > proposed patch Hi Sebastian, Can you mail the patch to 'glusterfs-patches.com' so it can be traced through 'patches.gluster.com'. Regards, Hi, I have just sent the patch to the address you mentioned. Previously I followed the instruction published on 'http://www.gluster.org/docs/index.php/Development_Work_Flow' page and sent the patch to 'gluster-devel'. Best Regards, Sebastian >
> Previously I followed the instruction published on
> 'http://www.gluster.org/docs/index.php/Development_Work_Flow' page and sent the
> patch to 'gluster-devel'.
>
Oops, If you have sent patch to 'gluster-devel' ML then its fine too, it will be received by the patchwork properly.
I've noticed that SuperFashHash function which is used in libglusterfs (in dict.c) is modified in such a way that it always returns the value of the second parameter of its invocation - len. This of course results in a lot of conflicts in resulting hash :) PATCH: http://patches.gluster.com/patch/812 in master (libglusterfs: fix SuperFastHash function used in dicitionaries in fact it always returned the value of second parameter (len) as a result.) |
Created attachment 37 [details] Slightly more elaborate strict_low_part patch