Bug 761887 (GLUSTER-155) - The SuperFastHash function used in dictionaries is broken.
Summary: The SuperFastHash function used in dictionaries is broken.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: GLUSTER-155
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: All
OS: All
low
medium
Target Milestone: ---
Assignee: Anand Avati
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-20 23:54 UTC by Sebastian Smyczyński
Modified: 2015-09-01 23:04 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:

Attachments (Terms of Use)
proposed patch (890 bytes, patch)
2009-07-20 21:12 UTC, Sebastian Smyczyński 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Sebastian Smyczyński 2009-07-20 21:12:13 UTC 
Created attachment 37 [details]
Slightly more elaborate strict_low_part patch
Comment 1 Amar Tumballi 2009-07-20 21:15:21 UTC 
(In reply to comment #1)
> Created an attachment (id=37) [details]
> proposed patch

Hi Sebastian, 
 Can you mail the patch to 'glusterfs-patches.com' so it can be traced through 'patches.gluster.com'.

Regards,
Comment 2 Sebastian Smyczyński 2009-07-20 21:27:31 UTC 
Hi,

I have just sent the patch to the address you mentioned.

Previously I followed the instruction published on 'http://www.gluster.org/docs/index.php/Development_Work_Flow' page and sent the patch to 'gluster-devel'.

Best Regards,
Sebastian
Comment 3 Amar Tumballi 2009-07-20 21:29:54 UTC 
> 
> Previously I followed the instruction published on
> 'http://www.gluster.org/docs/index.php/Development_Work_Flow' page and sent the
> patch to 'gluster-devel'.
> 

Oops, If you have sent patch to 'gluster-devel' ML then its fine too, it will be received by the patchwork properly.
Comment 4 Sebastian Smyczyński 2009-07-20 23:54:21 UTC 
I've noticed that SuperFashHash function which is used in libglusterfs (in dict.c) is modified in such a way that it always returns the value of the second parameter of its invocation - len. 

This of course results in a lot of conflicts in resulting hash :)
Comment 5 Anand Avati 2009-07-27 15:33:45 UTC 
PATCH: http://patches.gluster.com/patch/812 in master (libglusterfs: fix SuperFastHash function used in dicitionaries in fact it always returned the value of second parameter (len) as a result.)
Note You need to log in before you can comment on or make changes to this bug.