| Summary: | Improve the fix to forced alignment of dict serialization on armv5tel platforms. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Ted Bagg <tbagg> | ||||||
| Component: | unclassified | Assignee: | Vijay Bellur <vbellur> | ||||||
| Status: | CLOSED NOTABUG | QA Contact: | |||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 3.0.5 | CC: | amarts, gluster-bugs, raghavendra, vijay | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1470 | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
static inline
void cp32(char *d, char *s) { int i; for (i=4; i--;) d[i]=s[i]; }
optimizes to code that's almost, but not quite, as simple for armv5tel.
The memcpy() used in the existing fix (Bug 397) is not inlined by gcc -g -O2 on this platform. A better fix that replaces the 4-byte memcpy() with an inlined call is provided in the patches attached, one for 3.0.5 and one for the mainline as of about 24 Aug 2010. This should be competitive even on those platforms that would inline the memcpy(). Hi Ted, Thanks for the patches. But can you send the patches to 'glusterfs.com' or 'gluster-devel', so it shows up @ http://patches.gluster.com and becomes easy to commit. More info on how to help in patches here: http://www.gluster.com/community/documentation/index.php/Development_Work_Flow Regards, Amar Ted, Can you see if its working on armv5tel with latest master codebase (or use 3.1.2 release). I will be closing the bug as this patch is no more applicable.. but open a new bug if you see that its not working on that architecture. |
Created attachment 300 [details] patch for .spec file to use previous patch -- oops, forget to add changelog entry:)