Bug 763203 (GLUSTER-1471) - Improve the fix to forced alignment of dict serialization on armv5tel platforms.
Summary: Improve the fix to forced alignment of dict serialization on armv5tel platforms.
Keywords:
Status: CLOSED NOTABUG
Alias: GLUSTER-1471
Product: GlusterFS
Classification: Community
Component: unclassified
Version: 3.0.5
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Vijay Bellur
QA Contact:
URL: http://bugs.gluster.com/cgi-bin/bugzi...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-28 22:40 UTC by Ted Bagg
Modified: 2015-12-01 16:45 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:

Attachments (Terms of Use)
Improves the fix to forced alignment in armv5tel dict serialization. (2.47 KB, patch)
2010-08-28 19:40 UTC, Ted Bagg 		no flags Details | Diff
Similar improvement to the mainline as of about 24 Aug 2010. (2.47 KB, patch)
2010-08-28 19:44 UTC, Ted Bagg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Ted Bagg 2010-08-28 19:44:54 UTC 
Created attachment 300 [details]
patch for .spec file to use previous patch -- oops, forget to add changelog entry:)
Comment 1 Ted Bagg 2010-08-28 20:44:22 UTC 
static inline
void cp32(char *d, char *s) { int i; for (i=4; i--;) d[i]=s[i]; }
optimizes to code that's almost, but not quite, as simple for armv5tel.
Comment 2 Ted Bagg 2010-08-28 22:40:53 UTC 
The memcpy() used in the existing fix (Bug 397) is not inlined by gcc -g -O2 on this platform.  A better fix that replaces the 4-byte memcpy() with an inlined call is provided in the patches attached, one for 3.0.5 and one for the mainline as of about 24 Aug 2010.  This should be competitive even on those platforms that would inline the memcpy().
Comment 3 Amar Tumballi 2010-08-29 08:32:39 UTC 
Hi Ted,

Thanks for the patches. But can you send the patches to 'glusterfs.com' or 'gluster-devel', so it shows up @ http://patches.gluster.com and becomes easy to commit.

More info on how to help in patches here: http://www.gluster.com/community/documentation/index.php/Development_Work_Flow


Regards,
Amar
Comment 4 Amar Tumballi 2011-01-21 07:53:03 UTC 
Ted,
Can you see if its working on armv5tel with latest master codebase (or use 3.1.2 release).

I will be closing the bug as this patch is no more applicable.. but open a new bug if you see that its not working on that architecture.
Note You need to log in before you can comment on or make changes to this bug.