Bug 763885 (GLUSTER-2153)

Summary: glusterfs3.x does not match "generated" source
Product: [Community] GlusterFS Reporter: Jeff Darcy <jdarcy>
Component: unclassifiedAssignee: Amar Tumballi <amarts>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: mainlineCC: gluster-bugs, saurabh, vijay, vraman
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jeff Darcy 2010-11-24 15:08:57 UTC
No known version of rpcgen will even accept this file, due to the empty gf_dump_req definition.  Once that is worked around, it quickly becomes clear that the .x file does not in fact match the .c/.h files which are in git separately.  Nothing in the makefile even attempts to invoke rpcgen, or use the .x in any way.  It's a bit of a red herring for anyone who might consider adding operations or flags to the protocol in what would be the right way for most projects.

Comment 1 Amar Tumballi 2010-12-02 03:56:26 UTC
Yes! thats true. The reason we did some manual changes to the output of .x file is because, the files which are generated from 'rpcgen' used to emit some warnings of 'unused variable buf', which causes our patch inclusion process to fail, as we don't except any patches with warnings. 

Let me evaluate how to get over it, and have .x file included in build process.

Comment 2 Anand Avati 2011-02-19 04:32:30 UTC
PATCH: http://patches.gluster.com/patch/6212 in master (rpc/xdr: update .x files)

Comment 3 Saurabh 2011-03-11 02:48:04 UTC
saurabh@saurabh-laptop:~/git/glusterfs/rpc/xdr$ cd src
saurabh@saurabh-laptop:~/git/glusterfs/rpc/xdr/src$ ls
cli1.c      cli1-xdr.h   glusterd1.h      glusterd1-xdr.x  glusterfs3-xdr.c  Makefile.am  portmap-xdr.c  xdr-generic.c
cli1.h      cli1-xdr.x   glusterd1-xdr.c  glusterfs3.c     glusterfs3-xdr.h  portmap.c    portmap-xdr.h  xdr-generic.h
cli1-xdr.c  glusterd1.c  glusterd1-xdr.h  glusterfs3.h     glusterfs3-xdr.x  portmap.h    portmap-xdr.x
saurabh@saurabh-laptop:~/git/glusterfs/rpc/xdr/src$ rpcgen glusterd1-xdr.x 
saurabh@saurabh-laptop:~/git/glusterfs/rpc/xdr/src$ ls -lia