Hide Forgot
No known version of rpcgen will even accept this file, due to the empty gf_dump_req definition. Once that is worked around, it quickly becomes clear that the .x file does not in fact match the .c/.h files which are in git separately. Nothing in the makefile even attempts to invoke rpcgen, or use the .x in any way. It's a bit of a red herring for anyone who might consider adding operations or flags to the protocol in what would be the right way for most projects.
Yes! thats true. The reason we did some manual changes to the output of .x file is because, the files which are generated from 'rpcgen' used to emit some warnings of 'unused variable buf', which causes our patch inclusion process to fail, as we don't except any patches with warnings. Let me evaluate how to get over it, and have .x file included in build process.
PATCH: http://patches.gluster.com/patch/6212 in master (rpc/xdr: update .x files)
saurabh@saurabh-laptop:~/git/glusterfs/rpc/xdr$ cd src saurabh@saurabh-laptop:~/git/glusterfs/rpc/xdr/src$ ls cli1.c cli1-xdr.h glusterd1.h glusterd1-xdr.x glusterfs3-xdr.c Makefile.am portmap-xdr.c xdr-generic.c cli1.h cli1-xdr.x glusterd1-xdr.c glusterfs3.c glusterfs3-xdr.h portmap.c portmap-xdr.h xdr-generic.h cli1-xdr.c glusterd1.c glusterd1-xdr.h glusterfs3.h glusterfs3-xdr.x portmap.h portmap-xdr.x saurabh@saurabh-laptop:~/git/glusterfs/rpc/xdr/src$ rpcgen glusterd1-xdr.x saurabh@saurabh-laptop:~/git/glusterfs/rpc/xdr/src$ ls -lia