Bug 766604

Summary:	Review Request: Bashmount
Product:	[Fedora] Fedora	Reporter:	Harsh Verma <yevlempy>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	cedric.olivier, i.am.fedora.bk, james.hogarth, metherid, msuchy, package-review, yevlempy
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-11 11:12:38 EST	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---
Bug Depends On:
Bug Blocks:	201449

Description Harsh Verma 2011-12-12 07:28:04 EST

Spec URL: http://yevlempy.fedorapeople.org/bashmount.spec
SRPM URL: http://yevlempy.fedorapeople.org/bashmount-1.6.0-1.fc15.src.rpm
Description: Hi, i just packaged bashmount which is a menu-driven bash script that uses udisks to easily mount, unmount or eject removable devices without dependencies on any GUI or desktop environments. Its my first package.

Comment 1 Cédric OLIVIER 2011-12-12 13:35:02 EST

* Could you move %defattr at the top of %files (it's a cosmetic change, but %defattr tends to be used at the top of %files)

* Could you remove #Requires comments

* Could you remove "bash" build requires dependencies and add udisks(http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2)

For URL project page, http://sourceforge.net/projects/bashmount/ seems to be more complete than https://gitorious.org/bashmount/bashmount

Comment 2 Rahul Sundaram 2011-12-12 21:51:02 EST

* You can just drop the defattr completely since its fully redundant now.

Comment 3 Harsh Verma 2011-12-13 00:46:26 EST

Thanks folks for review. Have made the mentioned changes. Kindly check.

Spec URL: http://yevlempy.fedorapeople.org/bashmount.spec

Comment 4 Cédric OLIVIER 2011-12-13 07:30:58 EST

You have updated your spec file, so you can increase release number and fill in changelog.

Comment 5 Harsh Verma 2011-12-13 08:45:35 EST

Done

Comment 6 Rahul Sundaram 2011-12-14 03:18:03 EST

You have updated it only in the changelog.  Bump up the release number as well.  Post the new spec and srpm link.  Make sure you run rpmlint to check for errors and warnings.

Comment 7 Harsh Verma 2011-12-14 13:18:04 EST

My bad, i totally missed increasing the release number. Have fixed that.

Spec URL : http://yevlempy.fedorapeople.org/bashmount.spec
SRPM URL : http://yevlempy.fedorapeople.org/bashmount-1.6.0-2.fc15.src.rpm


As far as rpmlint is concerned, it gives no error but gives like around 8 warnings but that is basically due to spelling errors like udisks being taken as u disks in en_US, cant do anything about those kinda warnings. A different warning is, bashmount lacks a man page.

Comment 8 Miroslav Suchý 2015-07-21 09:22:43 EDT

Ping? Any progress here?
Harsh are you still interrested in this package?
Michael can you finish this review or reassign it back to nobody?

Comment 9 James Hogarth 2015-12-03 22:23:30 EST

Hi Harsh

It has been been quite some time since the last comments

Are you still intending to progress this?

As per policy if there is no update for a week this bug will be closed.

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

Comment 10 James Hogarth 2015-12-11 11:12:38 EST

It's been over a week with no response from the requestor to the NeedsInfo flag.

Closing as per policy.