Hide Forgot
Spec URL: http://yevlempy.fedorapeople.org/bashmount.spec SRPM URL: http://yevlempy.fedorapeople.org/bashmount-1.6.0-1.fc15.src.rpm Description: Hi, i just packaged bashmount which is a menu-driven bash script that uses udisks to easily mount, unmount or eject removable devices without dependencies on any GUI or desktop environments. Its my first package.
* Could you move %defattr at the top of %files (it's a cosmetic change, but %defattr tends to be used at the top of %files) * Could you remove #Requires comments * Could you remove "bash" build requires dependencies and add udisks(http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2) For URL project page, http://sourceforge.net/projects/bashmount/ seems to be more complete than https://gitorious.org/bashmount/bashmount
* You can just drop the defattr completely since its fully redundant now.
Thanks folks for review. Have made the mentioned changes. Kindly check. Spec URL: http://yevlempy.fedorapeople.org/bashmount.spec
You have updated your spec file, so you can increase release number and fill in changelog.
Done
You have updated it only in the changelog. Bump up the release number as well. Post the new spec and srpm link. Make sure you run rpmlint to check for errors and warnings.
My bad, i totally missed increasing the release number. Have fixed that. Spec URL : http://yevlempy.fedorapeople.org/bashmount.spec SRPM URL : http://yevlempy.fedorapeople.org/bashmount-1.6.0-2.fc15.src.rpm As far as rpmlint is concerned, it gives no error but gives like around 8 warnings but that is basically due to spelling errors like udisks being taken as u disks in en_US, cant do anything about those kinda warnings. A different warning is, bashmount lacks a man page.
Ping? Any progress here? Harsh are you still interrested in this package? Michael can you finish this review or reassign it back to nobody?
Hi Harsh It has been been quite some time since the last comments Are you still intending to progress this? As per policy if there is no update for a week this bug will be closed. https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
It's been over a week with no response from the requestor to the NeedsInfo flag. Closing as per policy.