| Summary: | Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Milan Broz <mbroz> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | agk, gwync, notting, package-review, pvrabec |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-21 16:36:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Milan Broz
2011-12-21 13:01:39 UTC
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
jthornber-thin-provisioning-tools-0.0.1-0-g4dcab4b.tar.gz :
MD5SUM this package : 31920fb9428b9a02b7e2b5681fd287fc
MD5SUM upstream package : upstream source not found
The source should be placed somewhere.
Instead of macros define, there should be used global. The global will work even in EL-6.
Upstream comment:
* in build.log is mentioned:
configure: WARNING: unrecognized options: --disable-dependency-tracking
The only real problem is missing source, when will you upload it somewhere?
comment in spec: # The source for this package was pulled from upstream's git. # Use the following URL to access the tarball: # https://github.com/jthornber/thin-provisioning-tools/tarball/%%{version} So https://github.com/jthornber/thin-provisioning-tools/tarball/0.0.1 will redirect to tar.gz download used in the srpm. unfortunately, github doesn't provide better way to access it (usable directly in Source0:) I hope Joe will place tar so some better location in future. global - yes, will change that. Bad github. Ok, conditionally APPROVED. New Package SCM Request ======================= Package Name: device-mapper-persistent-data Short Description: device-mapper persistent data tools Owners: lvm-team mbroz agk lvm-team is not in the packager group. It is group account, I think it cannot be in packager group.... see lvm2 package, lvm-team is the owner, here should be the same If it is not possible, please use me as the owner and I let Alasdair to complain somewhere, it is his idea to use lvm-team :-) Git done (by process-git-requests). I think I've managed to do what you want. -ish. (In reply to comment #8) > I think I've managed to do what you want. -ish. Hehe, now I am new maintainer. I assure you that I know nothing about device-mapper. Do'h. I misread the comments. Marcela, if you orphan in pkgdb, Milan can take it. Sorry. :( np, we fixed that already, thanks. The owner still needs changing to lvm-team so that bugzilla can pick up the correct mailing list owner: you'll probably need to open a ticket to request that. (spot wouldn't allow us to log in directly using the lvm-team account to set up things like that.) BTW Although it's not currently 'critical path', it will become so in due course. Fixed. |