Bug 769609 - Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Summary: Review Request: device-mapper-persistent-data - device-mapper thin provisioni...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-21 13:01 UTC by Milan Broz
Modified: 2013-03-01 04:11 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-21 16:36:53 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Milan Broz 2011-12-21 13:01:39 UTC
Spec URL: http://mbroz.fedorapeople.org/thinp/device-mapper-persistent-data.spec
SRPM URL: http://mbroz.fedorapeople.org/thinp/device-mapper-persistent-data-0.0.1-1.fc17.src.rpm
Description:
thin-provisioning-tools contains dump,restore and repair tools to
manage device-mapper thin provisioning target metadata devices.

Notes:
- package will later contain tools for another targets (like hierarchical storage management) that's why there is such generic name.

- rpmlint E: description-line-too-long C This package provides debug information for package device-mapper-persistent-data.
- filled bug #768393

- upstream tar location will perhaps change in  future (removing URL warning) and will include pre-generated autoconf files

Comment 1 Marcela Mašláňová 2011-12-21 13:56:07 UTC
[!]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
jthornber-thin-provisioning-tools-0.0.1-0-g4dcab4b.tar.gz :
  MD5SUM this package     : 31920fb9428b9a02b7e2b5681fd287fc
  MD5SUM upstream package : upstream source not found

The source should be placed somewhere.

Instead of macros define, there should be used global. The global will work even in EL-6.

Upstream comment:
 * in build.log is mentioned:
configure: WARNING: unrecognized options: --disable-dependency-tracking

The only real problem is missing source, when will you upload it somewhere?

Comment 2 Milan Broz 2011-12-21 14:31:05 UTC
comment in spec:
# The source for this package was pulled from upstream's git.
# Use the following URL to access the tarball:
# https://github.com/jthornber/thin-provisioning-tools/tarball/%%{version}

So
https://github.com/jthornber/thin-provisioning-tools/tarball/0.0.1
will redirect to tar.gz download used in the srpm.

unfortunately, github doesn't provide better way to access it
(usable directly in Source0:)

I hope Joe will place tar so some better location in future.

global - yes, will change that.

Comment 3 Marcela Mašláňová 2011-12-21 15:00:09 UTC
Bad github.

Ok, conditionally APPROVED.

Comment 4 Milan Broz 2011-12-21 15:21:52 UTC
New Package SCM Request
=======================
Package Name: device-mapper-persistent-data
Short Description: device-mapper persistent data tools
Owners: lvm-team mbroz agk

Comment 5 Gwyn Ciesla 2011-12-21 15:22:53 UTC
lvm-team is not in the packager group.

Comment 6 Milan Broz 2011-12-21 15:28:56 UTC
It is group account, I think it cannot be in packager group....
see lvm2 package, lvm-team is the owner, here should be the same

If it is not possible, please use me as the owner and I let Alasdair to complain somewhere, it is his idea to use lvm-team :-)

Comment 7 Gwyn Ciesla 2011-12-21 15:51:10 UTC
Git done (by process-git-requests).

Comment 8 Gwyn Ciesla 2011-12-21 15:53:05 UTC
I think I've managed to do what you want.  -ish.

Comment 9 Marcela Mašláňová 2011-12-21 15:56:57 UTC
(In reply to comment #8)
> I think I've managed to do what you want.  -ish.

Hehe, now I am new maintainer. I assure you that I know nothing about device-mapper.

Comment 10 Gwyn Ciesla 2011-12-21 16:10:59 UTC
Do'h.  I misread the comments.  Marcela, if you orphan in pkgdb, Milan can take it.  Sorry. :(

Comment 11 Milan Broz 2011-12-21 16:36:53 UTC
np, we fixed that already, thanks.

Comment 12 Alasdair Kergon 2011-12-22 01:48:01 UTC
The owner still needs changing to lvm-team so that bugzilla can pick up the correct mailing list owner: you'll probably need to open a ticket to request that.  (spot wouldn't allow us to log in directly using the lvm-team account to set up things like that.)

Comment 13 Alasdair Kergon 2011-12-22 01:52:14 UTC
BTW Although it's not currently 'critical path', it will become so in due course.

Comment 14 Gwyn Ciesla 2011-12-22 13:38:23 UTC
Fixed.


Note You need to log in before you can comment on or make changes to this bug.