Bug 772730
Summary: | Kernel panic after ACPI power event with x86_64 kernel | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Didier <d.bz-redhat> | ||||||||||||||||||
Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> | ||||||||||||||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||||||
Severity: | urgent | Docs Contact: | |||||||||||||||||||
Priority: | unspecified | ||||||||||||||||||||
Version: | 17 | CC: | 1800yolk, dwmw2, gansalmon, itamar, jfeeney, jonathan, kernel-maint, len.brown, madhu.chinakonda, mkhusid, tianyu.lan | ||||||||||||||||||
Target Milestone: | --- | ||||||||||||||||||||
Target Release: | --- | ||||||||||||||||||||
Hardware: | x86_64 | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Whiteboard: | first=3.1.6 tested=3.4.2 acpi | ||||||||||||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||||||
Doc Text: | Story Points: | --- | |||||||||||||||||||
Clone Of: | Environment: | ||||||||||||||||||||
Last Closed: | 2012-07-21 22:54:21 UTC | Type: | --- | ||||||||||||||||||
Regression: | --- | Mount Type: | --- | ||||||||||||||||||
Documentation: | --- | CRM: | |||||||||||||||||||
Verified Versions: | Category: | --- | |||||||||||||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||
Embargoed: | |||||||||||||||||||||
Attachments: |
|
Description
Didier
2012-01-09 19:58:26 UTC
Created attachment 551654 [details]
screenshot 1 of kernel panic
Created attachment 551655 [details]
screenshot 2 of kernel panic
Created attachment 551656 [details]
screenshot 3 of kernel panic
Created attachment 551658 [details]
i1090 dmesg (single user mode)
It seems the firmware is registering two devices with the same name (or so I'm told). Can you attach the output of acpidump? Created attachment 551677 [details] acpidump --output i1090_acpidump.out (In reply to comment #5) > Can you attach the output of acpidump? Thank you for the fast reply, Josh ; much appreciated. Attachment #5 [details]. OK, there are definitely two ACAD entries in the ACPI DSDT table. One is on the system bus, the other is off of PCI0 but the naming makes them ambiguous. I'll send this to linux-acpi Thank you, Josh. Would it be relevant if I'd attach i686 dmesg/acpi data, for the sake of comparison ? I can reproduce this crash at will on my Dell Inspiron Duo i1090 with 64-bit kernel. Stables with 32-bit one. I circumvented the x64 kernel crash by hibernating (instead of suspending) before attaching/detaching the power connector. Unfortunately, resume on hibernation is currently failing (starting with 3.2.x kernel series, I guess). Bugger ! *** Bug 767896 has been marked as a duplicate of this bug. *** In case more screenshots are needed: http://picasaweb.google.com/103156720104886162342/FedoraCrash [mass update] kernel-3.3.0-4.fc16 has been pushed to the Fedora 16 stable repository. Please retest with this update. [mass update] kernel-3.3.0-4.fc16 has been pushed to the Fedora 16 stable repository. Please retest with this update. [mass update] kernel-3.3.0-4.fc16 has been pushed to the Fedora 16 stable repository. Please retest with this update. I tested this morning with kernel-3.3.0-4.fc16 : - in single user mode, 4 or 5 subsequent power source changes yielded no oops ; - booted in initlevel 5, the power source change immediately invoked an oops. I will run a new batch of tests tomorrow. Created attachment 572207 [details]
screenshot 4 of kernel panic (kernel-3.3.0-4.fc16)
Tested with kernel-3.3.0-4.fc16 x86_64 ; the kernel still OOPSes, both in single- and multiuser.
I updated the screenshot (the 3.3.0 stack trace may reveal more info).
Tested with kernel-3.3.2-1.fc16.x86_64 : the kernel still panics. Kernel panic in F17 too (tested with kernel-3.3.7-1.fc17.x86_64). Tested with kernel-3.4.0-1.fc17.x86_64 (updates-testing repo) : the kernel still panics when connecting or removing an AC adapter. Panics with 3.4.2-4.fc17.x86_64. Not wanting to spam, so is there any use in me reporting failing kernels ? I poked linux-acpi upstream again. /* bows */ Created attachment 594375 [details]
debug.patch
hi Didier:
Can you try this patch and test again?
Dear Lan, The patch applied cleanly against kernel-3.4.4-3.fc17 (Fedora 17 updates-testing). I can now change power states at will without oopses ; thank you VERY much. I would be very much obliged if this patch could be accepted for the next kernel update. Status : CLOSED -> UPSTREAM ? Created attachment 595219 [details]
debug.patch
hi Didier:
Can you help me to test this patch which maybe more decent? If ok, I will send this one to acpi maillist. Thx.
Dear Lan, Due to vacation abroad, I'll be able to test in about two weeks ... I'll test it, but I'm not sure where to put that code. If you add a few instructions so I get the gist of it, I'd be happy to help Thanks. That's easy. Just add a check return value of power_supply_register() in the driver/acpi/ac.c. at line 295. result = power_supply_register(&ac->device->dev, &ac->charger); if (result) goto end I used to run Fedora on my Dell, but now I run arch.. I did a search for ac.c but there is no such file on the system, so clearly arch handles drivers differently. I found an ac.ko.gz file, and a few acpi related header files, but nothing that I could pin down as the driver. Sorry I couldn't help! Can you git a kernerl tree? git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git modified code, compile kernel and test. (In reply to comment #27) > Created attachment 595219 [details] This patch, applied to kernel 3.4.5-2.fc17, works perfectly. Thanks, Lan ! (In reply to comment #33) > (In reply to comment #27) > > Created attachment 595219 [details] > > This patch, applied to kernel 3.4.5-2.fc17, works perfectly. > > Thanks, Lan ! Thank you for testing Didier. Lan, if you post this upstream could you please put a link to it in this bug? We can get the patch added into the Fedora kernel shortly after that. hi josh: I have sent this patch to acpi maillist but no response. http://marc.info/?l=linux-acpi&m=134138075901658&w=2 (In reply to comment #35) > hi josh: > I have sent this patch to acpi maillist but no response. > > http://marc.info/?l=linux-acpi&m=134138075901658&w=2 That's fine. We'll pull it into Fedora for now and we can adjust the patch as needed. Many thanks again. Patch applied to all Fedora branches. kernel-3.4.6-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kernel-3.4.6-2.fc17 Package kernel-3.4.6-2.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kernel-3.4.6-2.fc17' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-10952/kernel-3.4.6-2.fc17 then log in and leave karma (feedback). kernel-3.4.6-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. kernel-3.4.6-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/kernel-3.4.6-1.fc16 shipped upstream in Linux-3.6-merge. was also cc: -stable commit f197ac13f6eeb351b31250b9ab7d0da17434ea36 Author: Lan Tianyu <tianyu.lan> Date: Fri Jul 20 13:29:16 2012 +0800 ACPI/AC: prevent OOPS on some boxes due to missing check power_supply_register() return value check kernel-3.4.6-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |